gclient_scm.py - Issue 541012: Allow gclient revert to remove symlinks - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(702)

My Issues | Starred Open | Closed | All

Unified Diff: gclient_scm.py

Issue 541012: Allow gclient revert to remove symlinks (Closed)

Patch Set: Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gclient_scm.py

diff --git a/gclient_scm.py b/gclient_scm.py

index 93f69974b83db0e4a10c0e9340c5ca2e4679734d..9aa0f0609ec8997286cabdc4fc1a3ce18327ca4f 100644

--- a/gclient_scm.py

+++ b/gclient_scm.py

@@ -485,7 +485,7 @@ class SVNWrapper(SCMWrapper, scm.SVN):

try:

if not os.path.exists(file_path):

pass

- elif os.path.isfile(file_path):

+ elif os.path.isfile(file_path) or os.path.islink(file_path):

logging.info('os.remove(%s)' % file_path)

os.remove(file_path)

elif os.path.isdir(file_path):

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698