Issue 5410001: Change trusted shared memory interface to match audio....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5410001: Change trusted shared memory interface to match audio.... (Closed)

Created:
10 years ago by nfullagar

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change trusted shared memory interface to match audio. - shm handle uint64_t -> int - more unification of shm size from int32_t -> uint32_t - GetNativeMemoryHandle() -> GetSharedMemory() BUG=none TEST=src/ppapi/examples/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67910

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Patch Set 14 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -55 lines)			Patch
M	ppapi/c/dev/ppb_buffer_dev.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/c/trusted/ppb_image_data_trusted.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+8 lines, -6 lines	0 comments	Download
M	ppapi/cpp/dev/buffer_dev.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ppapi/cpp/dev/buffer_dev.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppapi_messages.cc	View	1 2 3 4 5 6 7 8	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/proxy/ppapi_messages_internal.h	View	1 2 3 4 5 6 7	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppb_buffer_proxy.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_buffer_proxy.cc	View	1 2 3 4 5 6	5 chunks	+11 lines, -11 lines	0 comments	Download
M	ppapi/proxy/ppb_image_data_proxy.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_image_data_proxy.cc	View	1 2 3 4 5 6	8 chunks	+12 lines, -8 lines	0 comments	Download
M	ppapi/tests/test_buffer.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_buffer.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/plugins/pepper_buffer.cc	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/plugins/pepper_image_data.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_image_data.cc	View	1 2 3 4 5	3 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nfullagar

10 years ago (2010-12-02 00:10:27 UTC) #3

thx, committed at r67910

On Wed, Dec 1, 2010 at 2:47 PM, <brettw@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/5410001/
>

Expand Messages | Collapse Messages