Issue 5405003: Eliminate 'if defiend(CHECK) to avoid having to different binaries for the same template function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5405003: Eliminate 'if defiend(CHECK) to avoid having to different binaries for the same template function. (Closed)

Created:
10 years ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
satorux1

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Eliminate 'if defiend(CHECK) to avoid having to different binaries for the same template function. There is a new crash report but not caught by the CHECKS. (http://crash/reportdetail?reportid=accf4c24431527ce#crashing_thread) This could be because this ifdef generates two different objects of this template function and linker may be picking bad one. BUG=chromium-os:7327 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67913

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	base/tuple.h	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

lgtm