Copy recovery kernel to syslinux path only on x86.

Copy recovery kernel to syslinux path only on x86.

This is intended to fix a build error seen on ARM platforms where
the path "$esp_mnt/syslinux" does not exist.

Change-Id: I0b9e2d1fae376a7137d7e196901fbea4f2e796bc

BUG=http://code.google.com/p/chromium-os/issues/detail?id=9713
TEST=Not tested.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6edcc4d

[Will Drewry, 2010-11-29 23:37:16]

One minor bash v non-bash nit, but looks good otherwise.  Do you have a fresh
build you could run this on?

http://codereview.chromium.org/5404001/diff/7001/mod_image_for_recovery.sh
File mod_image_for_recovery.sh (right):

http://codereview.chromium.org/5404001/diff/7001/mod_image_for_recovery.sh#ne...
mod_image_for_recovery.sh:297: if [ "$ARCH" == "x86" ]; then
I'm pretty sure this should be a single '='.

[dhendrix, 2010-11-29 23:51:37]

Thanks for the quick review! I'm attempting to set up a new environment to get
some testing in.

http://codereview.chromium.org/5404001/diff/7001/mod_image_for_recovery.sh
File mod_image_for_recovery.sh (right):

http://codereview.chromium.org/5404001/diff/7001/mod_image_for_recovery.sh#ne...
mod_image_for_recovery.sh:297: if [ "$ARCH" == "x86" ]; then
On 2010/11/29 23:37:16, Will Drewry wrote:
> I'm pretty sure this should be a single '='.

Done. I always get confused here since bash allows both '=' and '=='. Maybe ==
is a bash-ism. I'm fine with either, so long as it works.

[Kenneth Waters, 2010-11-30 18:35:49]

Does this break autoupdate on ARM?

[Will Drewry, 2010-11-30 19:11:09]

On 2010/11/30 18:35:49, Kenneth Waters wrote:
> Does this break autoupdate on ARM?

This shouldn't change the postinst/setimage behavior since that should skip the
syslinux portions based on your changes, I think.

[Will Drewry, 2010-11-30 19:13:05]

lgtm once it's been through a test run!

http://codereview.chromium.org/5404001/diff/7001/mod_image_for_recovery.sh
File mod_image_for_recovery.sh (right):

http://codereview.chromium.org/5404001/diff/7001/mod_image_for_recovery.sh#ne...
mod_image_for_recovery.sh:297: if [ "$ARCH" == "x86" ]; then
On 2010/11/29 23:51:37, dhendrix wrote:
> On 2010/11/29 23:37:16, Will Drewry wrote:
> > I'm pretty sure this should be a single '='.
> 
> Done. I always get confused here since bash allows both '=' and '=='. Maybe ==
> is a bash-ism. I'm fine with either, so long as it works.

Yup - == should be fine, but = is the more cross-shell friendly variant for
string compares.  Thanks!

[Olof Johansson, 2010-12-01 01:15:49]

Tested it here, mod_image_for_recovery passed.

[dhendrix, 2010-12-01 01:21:44]

On 2010/12/01 01:15:49, Olof Johansson wrote:
> Tested it here, mod_image_for_recovery passed.

Thanks! Submitted.