Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 5402: Transition to pulling open-vcdiff rather than using a private snapshot pull... (Closed)

Created:
12 years, 2 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Transition to pulling open-vcdiff rather than using a private snapshot pull I can't include all the svn deletions (all of sdch/open_vcdiff/*) in this change list, as it will break reitveld. I'll do them piecemeal after a get an LGTM. Also, by temporarilly leaving in the old subtree, I can support mac until the move to use this new sub-tree. r=nsylvain,sgk Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2709

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -35 lines) Patch
M DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/base/sdch_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M sdch/SConscript View 1 chunk +1 line, -1 line 0 comments Download
M sdch/sdch.vcproj View 4 chunks +32 lines, -32 lines 0 comments Download
M sdch/using_sdch.vsprops View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jar (doing other things)
I originally just took a snapshot of open-vcdiff and checked it into our chromium tree. ...
12 years, 2 months ago (2008-09-30 00:55:44 UTC) #1
Mark Mentovai
LGTM, Mac fixes will be similar and simple.
12 years, 2 months ago (2008-09-30 00:58:47 UTC) #2
Nicolas Sylvain
LGTM!
12 years, 2 months ago (2008-09-30 01:01:13 UTC) #3
sgk
12 years, 2 months ago (2008-09-30 01:30:01 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698