Make DevTools client survive 'refresh' of the inspectable tab.

Make DevTools client survive 'refresh' of the inspectable tab.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12541

[yurys, 2009-03-26 10:47:27]

http://codereview.chromium.org/54002/diff/1/11
File chrome/renderer/devtools_agent.cc (right):

http://codereview.chromium.org/54002/diff/1/11#newcode185
Line 185: WebView* web_view = view_->webview();
you should check whether the view_ is not NULL

http://codereview.chromium.org/54002/diff/1/11#newcode193
Line 193: WebView* web_view = view_->webview();
you should check whether the view_ is not NULL

http://codereview.chromium.org/54002/diff/1/8
File webkit/glue/devtools/js/devtools.js (right):

http://codereview.chromium.org/54002/diff/1/8#newcode81
Line 81: var tools;
can you put this into devtools namespace?

http://codereview.chromium.org/54002/diff/1/8#newcode101
Line 101: WebInspector.ElementsTreeElement.prototype.updateChildren = function()
{
JS docs are missing here and below.

http://codereview.chromium.org/54002/diff/1/7
File webkit/glue/devtools/js/dom_agent.js (right):

http://codereview.chromium.org/54002/diff/1/7#newcode271
Line 271: /**
blank line above the JS doc

http://codereview.chromium.org/54002/diff/1/7#newcode275
Line 275: this.document = null;
style: private field should end with underscore

http://codereview.chromium.org/54002/diff/1/7#newcode276
Line 276: /**
blank line above the JS doc

http://codereview.chromium.org/54002/diff/1/7#newcode281
Line 281: /**
blank line above the JS doc

[pfeldman, 2009-03-26 11:00:42]

http://codereview.chromium.org/54002/diff/1/11
File chrome/renderer/devtools_agent.cc (right):

http://codereview.chromium.org/54002/diff/1/11#newcode185
Line 185: WebView* web_view = view_->webview();
On 2009/03/26 10:47:28, Yury Semikhatsky wrote:
> you should check whether the view_ is not NULL

Done.

http://codereview.chromium.org/54002/diff/1/11#newcode193
Line 193: WebView* web_view = view_->webview();
On 2009/03/26 10:47:28, Yury Semikhatsky wrote:
> you should check whether the view_ is not NULL

Done.

http://codereview.chromium.org/54002/diff/1/8
File webkit/glue/devtools/js/devtools.js (right):

http://codereview.chromium.org/54002/diff/1/8#newcode81
Line 81: var tools;
On 2009/03/26 10:47:28, Yury Semikhatsky wrote:
> can you put this into devtools namespace?

Done.

http://codereview.chromium.org/54002/diff/1/8#newcode101
Line 101: WebInspector.ElementsTreeElement.prototype.updateChildren = function()
{
On 2009/03/26 10:47:28, Yury Semikhatsky wrote:
> JS docs are missing here and below.

Done.

http://codereview.chromium.org/54002/diff/1/7
File webkit/glue/devtools/js/dom_agent.js (right):

http://codereview.chromium.org/54002/diff/1/7#newcode271
Line 271: /**
On 2009/03/26 10:47:28, Yury Semikhatsky wrote:
> blank line above the JS doc

Done.

http://codereview.chromium.org/54002/diff/1/7#newcode275
Line 275: this.document = null;
On 2009/03/26 10:47:28, Yury Semikhatsky wrote:
> style: private field should end with underscore

Done.

http://codereview.chromium.org/54002/diff/1/7#newcode276
Line 276: /**
On 2009/03/26 10:47:28, Yury Semikhatsky wrote:
> blank line above the JS doc

Done.

http://codereview.chromium.org/54002/diff/1/7#newcode281
Line 281: /**
On 2009/03/26 10:47:28, Yury Semikhatsky wrote:
> blank line above the JS doc

Done.

[yurys, 2009-03-26 11:05:49]

LGTM