Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5398002: doc stuff (Closed)

Created:
10 years ago by kathyw
Modified:
9 years, 7 months ago
Reviewers:
kurrik.chromium
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Doc changes TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68490

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 4

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1671 lines, -755 lines) Patch
M chrome/common/extensions/docs/a11y.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/api_index.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/api_other.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
A chrome/common/extensions/docs/apps.html View 1 1 chunk +683 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/autoupdate.html View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/background_pages.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/bookmarks.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/browserAction.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/content_scripts.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/contextMenus.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/cookies.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/crx.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/devguide.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/docs.html View 1 2 3 4 5 6 6 chunks +20 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/events.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.html View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/experimental.clipboard.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.contextMenus.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.cookies.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.history.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.idle.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.infobars.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.processes.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.proxy.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.sidebar.html View 1 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/experimental.webNavigation.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.webRequest.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/extension.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/external_extensions.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/faq.html View 1 2 20 chunks +40 lines, -38 lines 0 comments Download
M chrome/common/extensions/docs/getstarted.html View 1 2 5 chunks +4 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/history.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/hosting.html View 1 2 7 chunks +37 lines, -115 lines 0 comments Download
M chrome/common/extensions/docs/i18n.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/i18n-messages.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/idle.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/index.html View 1 2 3 4 5 6 5 chunks +49 lines, -68 lines 0 comments Download
M chrome/common/extensions/docs/management.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/manifest.html View 1 2 3 4 5 6 20 chunks +74 lines, -41 lines 0 comments Download
M chrome/common/extensions/docs/match_patterns.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/messaging.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/notifications.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/npapi.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/omnibox.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/options.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/override.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/overview.html View 1 2 3 4 5 6 13 chunks +95 lines, -29 lines 0 comments Download
M chrome/common/extensions/docs/packaging.html View 1 2 3 4 5 6 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/pageAction.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/permission_warnings.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
A chrome/common/extensions/docs/static/apps.html View 1 1 chunk +171 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/autoupdate.html View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/static/docs.html View 1 2 3 4 5 6 2 chunks +17 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/static/experimental.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/static/faq.html View 1 16 chunks +37 lines, -35 lines 0 comments Download
M chrome/common/extensions/docs/static/getstarted.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/docs/static/hosting.html View 1 2 chunks +30 lines, -101 lines 0 comments Download
M chrome/common/extensions/docs/static/index.html View 1 2 3 4 5 6 1 chunk +50 lines, -65 lines 0 comments Download
M chrome/common/extensions/docs/static/manifest.html View 1 2 3 4 5 6 15 chunks +69 lines, -38 lines 0 comments Download
M chrome/common/extensions/docs/static/overview.html View 1 2 3 4 5 6 6 chunks +94 lines, -22 lines 0 comments Download
M chrome/common/extensions/docs/static/packaging.html View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/static/tabs.html View 1 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/tabs.html View 1 6 chunks +14 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/template/api_template.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/themes.html View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/tut_analytics.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/tut_debugging.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/tut_oauth.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/tutorials.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/whats_new.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/windows.html View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/xhr.html View 1 4 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kurrik.chromium
Took a quick look over. Looks pretty good. http://codereview.chromium.org/5398002/diff/7001/chrome/common/extensions/docs/static/faq.html File chrome/common/extensions/docs/static/faq.html (right): http://codereview.chromium.org/5398002/diff/7001/chrome/common/extensions/docs/static/faq.html#newcode12 chrome/common/extensions/docs/static/faq.html:12: <!-- ...
10 years ago (2010-12-07 05:16:30 UTC) #1
kathyw
http://codereview.chromium.org/5398002/diff/7001/chrome/common/extensions/docs/static/faq.html File chrome/common/extensions/docs/static/faq.html (right): http://codereview.chromium.org/5398002/diff/7001/chrome/common/extensions/docs/static/faq.html#newcode12 chrome/common/extensions/docs/static/faq.html:12: <!-- PENDING: add a link to store help --> ...
10 years ago (2010-12-07 06:43:32 UTC) #2
kurrik.chromium
10 years ago (2010-12-13 18:05:22 UTC) #3 
Sorry, missed this last week.  LGTM.

~Arne

On 2010/12/07 06:43:32, kathyw wrote:
>
http://codereview.chromium.org/5398002/diff/7001/chrome/common/extensions/doc...
> File chrome/common/extensions/docs/static/faq.html (right):
> 
>
http://codereview.chromium.org/5398002/diff/7001/chrome/common/extensions/doc...
> chrome/common/extensions/docs/static/faq.html:12: <!-- PENDING: add a link to
> store help -->
> On 2010/12/07 05:16:30, kurrik.chromium wrote:
> > Just making sure you didn't forget to add this
> 
> I'll add it to my list...
> 
>
http://codereview.chromium.org/5398002/diff/7001/chrome/common/extensions/doc...
> File chrome/common/extensions/docs/static/manifest.html (right):
> 
>
http://codereview.chromium.org/5398002/diff/7001/chrome/common/extensions/doc...
> chrome/common/extensions/docs/static/manifest.html:299: Hosted apps can use
only
> HTML5-related permissions
> On 2010/12/07 05:16:30, kurrik.chromium wrote:
> > HTML5-related is a bit confusing.  "Web-related"?  Or just enumerate the
> > permissions here?  Feel free to ignore if you disagree.
> 
> I've changed it. Take another look?

Powered by Google App Engine
This is Rietveld 408576698