Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 5392001: Add extension API test for FileSystem API. (Closed)

Created:
10 years ago by kinuko
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add extension API test for FileSystem API. BUG=61534 TEST=ExtensionApiTest.FileAPI Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68418

Patch Set 1 #

Total comments: 2

Patch Set 2 : added cleanup code in tab.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
A chrome/browser/extensions/extension_fileapi_apitest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/fileapi/background.html View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/fileapi/manifest.json View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/fileapi/tab.html View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
10 years ago (2010-11-29 23:37:29 UTC) #1
ericu
http://codereview.chromium.org/5392001/diff/1/chrome/test/data/extensions/api_test/fileapi/background.html File chrome/test/data/extensions/api_test/fileapi/background.html (right): http://codereview.chromium.org/5392001/diff/1/chrome/test/data/extensions/api_test/fileapi/background.html#newcode10 chrome/test/data/extensions/api_test/fileapi/background.html:10: fileSystem.root.getDirectory('dir', {create:true}, Is there ever any cleanup done between ...
10 years ago (2010-12-01 00:58:45 UTC) #2
kinuko
http://codereview.chromium.org/5392001/diff/1/chrome/test/data/extensions/api_test/fileapi/background.html File chrome/test/data/extensions/api_test/fileapi/background.html (right): http://codereview.chromium.org/5392001/diff/1/chrome/test/data/extensions/api_test/fileapi/background.html#newcode10 chrome/test/data/extensions/api_test/fileapi/background.html:10: fileSystem.root.getDirectory('dir', {create:true}, On 2010/12/01 00:58:46, ericu wrote: > Is ...
10 years ago (2010-12-01 03:17:59 UTC) #3
ericu
10 years ago (2010-12-04 02:23:02 UTC) #4
Kinuko, I'm sorry not to have responded faster--this slipped off my radar.

LGTM

Powered by Google App Engine
This is Rietveld 408576698