Chromium Code Reviews

Issue 539001: Added hello-triangle demo.... (Closed)

Created:
10 years, 11 months ago by alokp
Modified:
9 years, 6 months ago
Reviewers:
Vangelis Kokkevis, apatrick
CC:
chromium-reviews_googlegroups.com, apatrick_chromium
Visibility:
Public.

Description

Added hello-triangle demo. BUG=26099 TEST=Try running hello_triangle executable, you should see a red triangle Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35873

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Stats (+80 lines, -0 lines)
A gpu/demos/DEPS View 1 chunk +3 lines, -0 lines 0 comments
M gpu/demos/demos.gyp View 1 chunk +11 lines, -0 lines 0 comments
A gpu/demos/hello_triangle/main.cc View 1 chunk +66 lines, -0 lines 0 comments

Messages

Total messages: 3 (0 generated)
alokp
10 years, 11 months ago (2010-01-09 03:02:11 UTC) #1
apatrick
LGTM http://codereview.chromium.org/539001/diff/1/2 File gpu/demos/hello_triangle/main.cc (right): http://codereview.chromium.org/539001/diff/1/2#newcode26 gpu/demos/hello_triangle/main.cc:26: HTUserData user_data_; I think you should add this ...
10 years, 11 months ago (2010-01-09 03:07:06 UTC) #2
alokp
10 years, 11 months ago (2010-01-09 06:00:36 UTC) #3 
http://codereview.chromium.org/539001/diff/1/2
File gpu/demos/hello_triangle/main.cc (right):

http://codereview.chromium.org/539001/diff/1/2#newcode26
gpu/demos/hello_triangle/main.cc:26: HTUserData user_data_;
On 2010/01/09 03:07:06, apatrick wrote:
> I think you should add this as the last line:
> DISALLOW_COPY_AND_ASSIGN(HelloTriangle);
> 
> Ditto in the base class if it isn't already there.

Done.

Powered by Google App Engine