Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 5389004: Merge 72807 - 2010-11-24 Dimitri Glazkov <dglazkov@chromium.org>... (Closed)

Created:
10 years ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
dglazkov
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/597/
Visibility:
Public.

Description

Merge 72807 - 2010-11-24 Dimitri Glazkov <dglazkov@chromium.org>; Reviewed by Darin Adler. REGRESSION (r71934): Main search field at Apple tech specs does not accept typing https://bugs.webkit.org/show_bug.cgi?id=49868 * fast/forms/disabled-search-input-expected.txt: Added. * fast/forms/disabled-search-input.html: Added. 2010-11-24 Dimitri Glazkov <dglazkov@chromium.org>; Reviewed by Darin Adler. REGRESSION (r71934): Main search field at Apple tech specs does not accept typing https://bugs.webkit.org/show_bug.cgi?id=49868 The problem here was that the inner text element of search input was first laid out as disabled and thus with a 0-height. This would prevent a hit test to ever reach it, even if it's enabled. Test: fast/forms/disabled-search-input.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasLineIfEmpty): Removed a check for textarea that is no longer necessary. * rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty): Added an override to ensure that an empty inner text element is always one-line high. TBR=dglazkov@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -866 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +0 lines, -343 lines 0 comments Download
A + LayoutTests/fast/forms/disabled-search-input.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/disabled-search-input-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +0 lines, -524 lines 0 comments Download
M WebCore/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M WebCore/rendering/TextControlInnerElements.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dglazkov
10 years ago (2010-11-30 18:51:44 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698