net: Remove typedef net::URLRequest URLRequest;

net: Remove typedef net::URLRequest URLRequest;

BUG=64263
TEST=compiled locally, trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67762

[tfarina, 2010-11-28 20:40:46]

Please, take a look.

[willchan no longer on Chromium, 2010-11-29 19:13:17]

LGTM!

On Sun, Nov 28, 2010 at 12:40 PM, <tfarina@chromium.org> wrote:

> Reviewers: willchan, wtc,
>
> Message:
> Please, take a look.
>
> Description:
> net: Remove typedef net::URLRequest URLRequest;
>
> BUG=64263
> TEST=compiled locally, trybots
>
> Please review this at http://codereview.chromium.org/5384002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M base/debug/leak_tracker.h
>  M chrome/browser/appcache/view_appcache_internals_job_factory.cc
>  M chrome/browser/autocomplete/autocomplete.cc
>  M chrome/browser/automation/url_request_automation_job.h
>  M chrome/browser/automation/url_request_automation_job.cc
>  M chrome/browser/browser_main.cc
>  M chrome/browser/child_process_security_policy.cc
>  M chrome/browser/child_process_security_policy_unittest.cc
>  M chrome/browser/chrome_plugin_host.cc
>  M chrome/browser/chrome_plugin_unittest.cc
>  M chrome/browser/chromeos/gview_request_interceptor.h
>  M chrome/browser/chromeos/gview_request_interceptor.cc
>  M chrome/browser/chromeos/gview_request_interceptor_unittest.cc
>  M chrome/browser/chromeos/login/account_screen_browsertest.cc
>  M chrome/browser/chromeos/login/registration_screen.cc
>  M chrome/browser/debugger/devtools_http_protocol_handler.h
>  M chrome/browser/debugger/devtools_http_protocol_handler.cc
>  M chrome/browser/debugger/devtools_netlog_observer.cc
>  M chrome/browser/dom_ui/chrome_url_data_manager.cc
>  M chrome/browser/dom_ui/mediaplayer_ui.h
>  M chrome/browser/dom_ui/mediaplayer_ui.cc
>  M chrome/browser/download/save_package.h
>  M chrome/browser/extensions/autoupdate_interceptor.h
>  M chrome/browser/extensions/autoupdate_interceptor.cc
>  M chrome/browser/extensions/extension_protocols.cc
>  M chrome/browser/extensions/user_script_listener.cc
>  M chrome/browser/extensions/user_script_listener_unittest.cc
>  M chrome/browser/io_thread.cc
>  M chrome/browser/login_prompt.h
>  M chrome/browser/login_prompt.cc
>  M chrome/browser/login_prompt_gtk.cc
>  M chrome/browser/login_prompt_mac.mm
>  M chrome/browser/login_prompt_win.cc
>  M chrome/browser/net/blob_url_request_job_factory.cc
>  M chrome/browser/net/chrome_dns_cert_provenance_checker.cc
>  M chrome/browser/net/connect_interceptor.h
>  M chrome/browser/net/connect_interceptor.cc
>  M chrome/browser/net/connection_tester.cc
>  M chrome/browser/net/load_timing_observer.cc
>  M chrome/browser/net/load_timing_observer_unittest.cc
>  M chrome/browser/net/metadata_url_request.cc
>  M chrome/browser/net/passive_log_collector.h
>  M chrome/browser/net/prerender_interceptor.h
>  M chrome/browser/net/prerender_interceptor.cc
>  M chrome/browser/net/prerender_interceptor_unittest.cc
>  M chrome/browser/net/url_request_failed_dns_job.cc
>  M chrome/browser/net/url_request_mock_http_job.h
>  M chrome/browser/net/url_request_mock_http_job.cc
>  M chrome/browser/net/url_request_mock_link_doctor_job.h
>  M chrome/browser/net/url_request_mock_link_doctor_job.cc
>  M chrome/browser/net/url_request_mock_net_error_job.h
>  M chrome/browser/net/url_request_mock_net_error_job.cc
>  M chrome/browser/net/url_request_mock_util.cc
>  M chrome/browser/net/url_request_slow_download_job.cc
>  M chrome/browser/net/url_request_slow_http_job.h
>  M chrome/browser/net/url_request_slow_http_job.cc
>  M chrome/browser/net/url_request_tracking.cc
>  M chrome/browser/net/view_blob_internals_job_factory.cc
>  M chrome/browser/net/view_http_cache_job_factory.cc
>  M chrome/browser/plugin_download_helper.h
>  M chrome/browser/plugin_download_helper.cc
>  M chrome/browser/policy/device_management_service_browsertest.cc
>  M chrome/browser/printing/print_dialog_cloud_uitest.cc
>  M chrome/browser/renderer_host/async_resource_handler.cc
>  M chrome/browser/renderer_host/buffered_resource_handler.cc
>  M chrome/browser/renderer_host/cross_site_resource_handler.cc
>  M chrome/browser/renderer_host/download_resource_handler.cc
>  M chrome/browser/renderer_host/download_throttling_resource_handler.cc
>  M chrome/browser/renderer_host/global_request_id.h
>  M chrome/browser/renderer_host/offline_resource_handler.cc
>  M chrome/browser/renderer_host/resource_dispatcher_host.h
>  M chrome/browser/renderer_host/resource_dispatcher_host.cc
>  M chrome/browser/renderer_host/resource_dispatcher_host_request_info.h
>  M chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc
>  M chrome/browser/renderer_host/resource_handler.h
>  M chrome/browser/renderer_host/resource_queue.h
>  M chrome/browser/renderer_host/resource_queue.cc
>  M chrome/browser/renderer_host/resource_queue_unittest.cc
>  M chrome/browser/renderer_host/resource_request_details.h
>  M chrome/browser/renderer_host/resource_request_details.cc
>  M chrome/browser/renderer_host/safe_browsing_resource_handler.cc
>  M chrome/browser/renderer_host/sync_resource_handler.cc
>  M chrome/browser/renderer_host/test/render_view_host_unittest.cc
>  M chrome/browser/renderer_host/x509_user_cert_resource_handler.cc
>  M chrome/browser/ssl/ssl_add_cert_handler.cc
>  M chrome/browser/ssl/ssl_cert_error_handler.cc
>  M chrome/browser/ssl/ssl_client_auth_handler.h
>  M chrome/browser/ssl/ssl_client_auth_handler.cc
>  M chrome/browser/ssl/ssl_error_handler.h
>  M chrome/browser/ssl/ssl_error_handler.cc
>  M chrome/browser/ssl/ssl_manager.h
>  M chrome/browser/ssl/ssl_manager.cc
>  M chrome/browser/tab_contents/render_view_context_menu.cc
>  M chrome/browser/ui/browser_init.cc
>  M chrome/common/chrome_switches.cc
>  M chrome/common/net/url_fetcher.h
>  M chrome/common/net/url_fetcher.cc
>  M chrome/common/net/url_fetcher_unittest.cc
>  M chrome/common/net/url_request_intercept_job.cc
>  M chrome/common/render_messages_params.h
>  M chrome_frame/test/net/test_automation_provider.cc
>  M chrome_frame/test/test_server_test.cc
>  M net/base/load_flags_list.h
>  M net/base/load_states.h
>  M net/base/net_log.h
>  M net/base/net_log_event_type_list.h
>  M net/base/net_util.h
>  M net/ocsp/nss_ocsp.cc
>  M net/proxy/proxy_script_fetcher_impl.h
>  M net/proxy/proxy_script_fetcher_impl.cc
>  M net/proxy/proxy_script_fetcher_impl_unittest.cc
>  M net/spdy/spdy_network_transaction_unittest.cc
>  M net/url_request/https_prober.h
>  M net/url_request/https_prober.cc
>  M net/url_request/url_request.h
>  M net/url_request/url_request.cc
>  M net/url_request/url_request_about_job.h
>  M net/url_request/url_request_about_job.cc
>  M net/url_request/url_request_context.h
>  M net/url_request/url_request_data_job.cc
>  M net/url_request/url_request_file_dir_job.cc
>  M net/url_request/url_request_file_job.h
>  M net/url_request/url_request_file_job.cc
>  M net/url_request/url_request_filter.h
>  M net/url_request/url_request_filter.cc
>  M net/url_request/url_request_ftp_job.cc
>  M net/url_request/url_request_http_job.cc
>  M net/url_request/url_request_job.h
>  M net/url_request/url_request_job.cc
>  M net/url_request/url_request_job_manager.h
>  M net/url_request/url_request_job_manager.cc
>  M net/url_request/url_request_job_tracker.h
>  M net/url_request/url_request_job_tracker.cc
>  M net/url_request/url_request_job_tracker_unittest.cc
>  M net/url_request/url_request_netlog_params.h
>  M net/url_request/url_request_test_job.h
>  M net/url_request/url_request_test_job.cc
>  M net/url_request/url_request_unittest.h
>  M net/url_request/url_request_unittest.cc
>  M tools/heapcheck/suppressions.txt
>  M webkit/appcache/appcache_host.cc
>  M webkit/appcache/appcache_interceptor.h
>  M webkit/appcache/appcache_interceptor.cc
>  M webkit/appcache/appcache_interfaces.cc
>  M webkit/appcache/appcache_request_handler.h
>  M webkit/appcache/appcache_request_handler.cc
>  M webkit/appcache/appcache_request_handler_unittest.cc
>  M webkit/appcache/appcache_update_job.h
>  M webkit/appcache/appcache_update_job.cc
>  M webkit/appcache/appcache_update_job_unittest.cc
>  M webkit/appcache/appcache_url_request_job.cc
>  M webkit/appcache/appcache_url_request_job_unittest.cc
>  M webkit/appcache/view_appcache_internals_job.cc
>  M webkit/blob/blob_storage_controller.cc
>  M webkit/blob/blob_url_request_job.cc
>  M webkit/blob/blob_url_request_job_unittest.cc
>  M webkit/blob/view_blob_internals_job.cc
>  M webkit/fileapi/file_system_operation.cc
>  M webkit/fileapi/file_writer_delegate.h
>  M webkit/fileapi/file_writer_delegate.cc
>  M webkit/glue/resource_loader_bridge.h
>  M webkit/tools/test_shell/simple_appcache_system.cc
>  M webkit/tools/test_shell/simple_resource_loader_bridge.cc
>  M webkit/tools/test_shell/test_shell.cc
>
>
>

[wtc, 2010-11-30 19:23:01]

tfarina: I don't have the stamina to review this huge
changelist.  So willchan's LGTM is enough.  Don't wait
for me.  Thank you for working on this.

[wtc, 2010-11-30 19:29:07]

I only reviewed url_request.{h,cc} and url_request_job.{h,cc}.
I suggested two changes below.

http://codereview.chromium.org/5384002/diff/1/net/url_request/url_request_job.cc
File net/url_request/url_request_job.cc (right):

http://codereview.chromium.org/5384002/diff/1/net/url_request/url_request_job...
net/url_request/url_request_job.cc:28:
URLRequestJob::URLRequestJob(net::URLRequest* request)
Instead of adding net:: to this file, please put this file
inside the 'net' namespace.

http://codereview.chromium.org/5384002/diff/1/net/url_request/url_request_job.h
File net/url_request/url_request_job.h (right):

http://codereview.chromium.org/5384002/diff/1/net/url_request/url_request_job...
net/url_request/url_request_job.h:68: // delete their net::URLRequest object,
even when doing a cancel. The default
Nit: inside the 'net' namespace, you don't need to use the
net:: prefix in either code or comments.

[tfarina, 2010-11-30 21:46:09]

Submitted, hopefully no one have added other instances of URLRequest until I
have landed this.

http://codereview.chromium.org/5384002/diff/1/net/url_request/url_request_job.cc
File net/url_request/url_request_job.cc (right):

http://codereview.chromium.org/5384002/diff/1/net/url_request/url_request_job...
net/url_request/url_request_job.cc:28:
URLRequestJob::URLRequestJob(net::URLRequest* request)
On 2010/11/30 19:29:08, wtc wrote:
> Instead of adding net:: to this file, please put this file
> inside the 'net' namespace.

Done.

[wtc, 2010-11-30 21:51:33]

http://codereview.chromium.org/5384002/diff/8001/net/url_request/url_request_...
File net/url_request/url_request_job.cc (right):

http://codereview.chromium.org/5384002/diff/8001/net/url_request/url_request_...
net/url_request/url_request_job.cc:26: const int URLRequestJob::kFilterBufSize =
32 * 1024;
This static (const) member of URLRequestJob should also be
inside the 'net' namespace.  (You will need to deal with this
when you remove the net::URLRequestJob typedef.)