Refactor ZLib and Verbatim encoders.

remoting/host/capturer_linux.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/capturer_linux.h"
 
 #include <X11/Xlib.h>
 #include <X11/Xutil.h>
 #include <X11/extensions/Xdamage.h>
 
@@ skipping 192 matching lines @@
   InvalidRects invalid_rects;
   for (int i = 0; i < events_to_process; i++) {
     XNextEvent(display_, &e);
     if (e.type == damage_event_base_ + XDamageNotify) {
       // If we're doing a full screen capture, we should just drain the events.
       if (!capture_fullscreen_) {
         XDamageNotifyEvent *event = reinterpret_cast<XDamageNotifyEvent*>(&e);
         gfx::Rect damage_rect(event->area.x, event->area.y, event->area.width,
                               event->area.height);
         invalid_rects.insert(damage_rect);
-        VLOG(3) << "Damage receved for rect at ("
+        LOG(WARNING) << "Damage receved for rect at ("

[garykac, 2010/12/02 19:51:31]

received

                 << damage_rect.x() << "," << damage_rect.y() << ") size ("
                 << damage_rect.width() << "," << damage_rect.height() << ")";
       }
     } else {
       LOG(WARNING) << "Got unknown event type: " << e.type;
     }
   }
 
   if (capture_fullscreen_) {
     capturer_->InvalidateFullScreen();
-    capture_fullscreen_ = false;
+    //    capture_fullscreen_ = false;

[Alpha Left Google, 2010/12/02 19:39:55]

commented out code?

[garykac, 2010/12/02 19:51:31]

Why is this commented out?  Does it need a TODO?

[Sergey Ulanov, 2010/12/03 00:17:21]

This wasn't meant to be part of this CL (Linux capturer is currently broken, so
I had to comment this line to workaround it). Reverted now

   } else {
     capturer_->InvalidateRects(invalid_rects);
   }
 }
 
 void CapturerLinuxPimpl::CaptureRects(
     const InvalidRects& rects,
     Capturer::CaptureCompletedCallback* callback) {
   uint8* buffer = buffers_[capturer_->current_buffer_];
   DataPlanes planes;
@@ skipping 103 matching lines @@
     }
   }
 }
 
 // static
 Capturer* Capturer::Create(MessageLoop* message_loop) {
   return new CapturerLinux(message_loop);
 }
 
 }  // namespace remoting