Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 538005: linux: grab device name before closing it (Closed)

Created:
10 years, 11 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
awong
CC:
chromium-reviews_googlegroups.com, scherkus (not reviewing), fbarchard, awong, Alpha Left Google
Visibility:
Public.

Description

linux: grab device name before closing it PcmClose frees the handle regardless of whether there's an error while shutting down, so grab the PcmName result first in case we want to use it in an error message. BUG=20006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35837

Patch Set 1 #

Patch Set 2 : better message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M media/audio/linux/alsa_output.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
(i confirmed this by checking the alsa source)
10 years, 11 months ago (2010-01-08 21:54:15 UTC) #1
awong
10 years, 11 months ago (2010-01-08 21:58:41 UTC) #2
LGTM.

Good catch!

Powered by Google App Engine
This is Rietveld 408576698