Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 5380005: Enable Selenium test for chrome Frame... (Closed)

Created:
10 years ago by amit
Modified:
9 years ago
Reviewers:
robertshield
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Enable Selenium test for chrome Frame as now we have selenium checkout on bots and it should work BUG=50372 TEST=FullTabSeleniumTest.Core Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome_frame/test/navigation_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
amit
10 years ago (2010-11-30 15:21:18 UTC) #1
robertshield
10 years ago (2010-11-30 15:48:12 UTC) #2
LGTM

On Tue, Nov 30, 2010 at 10:21 AM, <amit@chromium.org> wrote:

> Reviewers: robertshield,
>
> Description:
> Enable Selenium test for chrome Frame
>
> as now we have selenium checkout on bots and it should work
> BUG=50372
> TEST=FullTabSeleniumTest.Core
>
>
>
> Please review this at http://codereview.chromium.org/5380005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/navigation_test.cc
>
>
> Index: chrome_frame/test/navigation_test.cc
> ===================================================================
> --- chrome_frame/test/navigation_test.cc        (revision 67268)
> +++ chrome_frame/test/navigation_test.cc        (working copy)
> @@ -977,7 +977,7 @@
>  }
>
>  // Tests refreshing causes a page load.
> -TEST_F(FullTabSeleniumTest, DISABLED_Core) {
> +TEST_F(FullTabSeleniumTest, Core) {
>   server_mock_.ExpectAndServeAnyRequests(CFInvocation::HttpHeader());
>   std::wstring url = GetTestUrl(L"core/TestRunner.html");
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698