Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: src/property_changed_handler.h

Issue 5380002: cashew: defer all D-Bus signal processing to main loop (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/cashew.git@master
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/property_changed_handler.h
diff --git a/src/property_changed_handler.h b/src/property_changed_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..07689e4579e6057f31844dff87fa40d68959f346
--- /dev/null
+++ b/src/property_changed_handler.h
@@ -0,0 +1,82 @@
+// Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SRC_PROPERTY_CHANGED_HANDLER_H_
+#define SRC_PROPERTY_CHANGED_HANDLER_H_
+
+#include <glib.h>
+
+#include <queue>
+#include <string>
+#include <utility>
+
+#include <base/basictypes.h> // NOLINT
+#include <dbus-c++/dbus.h> // NOLINT
+
+namespace cashew {
+
+class PropertyChangedDelegate;
+
+// tuple of (property name, new property value) representing a D-Bus
+// PropertyChanged signal
+typedef std::pair<const std::string, const DBus::Variant> PropertyChangedSignal;
+
+// queue of PropertyChangedSignal tuples
+typedef std::queue<PropertyChangedSignal> PropertyChangedQueue;
+
+// PropertyChangedHandler allows tuples representing D-Bus PropertyChanged
+// signals to be enqueued for deferred handling from the glib main loop.
+class PropertyChangedHandler {
+ public:
+ PropertyChangedHandler();
+ virtual ~PropertyChangedHandler();
+
+ // set delegate that will receive OnPropertyChanged callbacks
+ // ok to clear delegate by setting it to NULL
+ virtual void delegate(PropertyChangedDelegate *delegate);
+
+ // add a PropertyChangedSignal to |signal_queue_|
+ // schedules a glib callback for deferred signal processing if one is not
+ // already scheduled
+ virtual void EnqueueSignal(const PropertyChangedSignal& signal);
+
+ private:
+ // delegate for OnPropertyChanged callbacks
+ PropertyChangedDelegate *delegate_;
+
+ // glib source id for deferred processing callback
+ guint source_id_;
+
+ // queue of PropertyChangedSignal tuples awaiting deferred processing
+ PropertyChangedQueue signal_queue_;
+
+ // glib integration: static wrapper
+ // takes PropertyChangedDelegate as data and invokes
+ // delegate->OnPropertyChanged for each signal in |signal_queue_|
+ static gboolean StaticOnPropertyChangedCallback(gpointer data);
+
+ // clear |signal_queue_|
+ void DeletePendingSignals();
+
+ DISALLOW_COPY_AND_ASSIGN(PropertyChangedHandler);
+};
+
+// callback interface for deferred PropertyChanged signal processing
+class PropertyChangedDelegate {
+ public:
+ PropertyChangedDelegate() {}
+ virtual ~PropertyChangedDelegate() {}
+
+ // callback method for deferred PropertyChanged signal processing
+ virtual void OnPropertyChanged(const PropertyChangedHandler *handler,
+ const std::string& property_name,
+ const DBus::Variant& new_value) = 0;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(PropertyChangedDelegate);
+};
+
+} // namespace cashew
+
+#endif // SRC_PROPERTY_CHANGED_HANDLER_H_
« no previous file with comments | « src/main.cc ('k') | src/property_changed_handler.cc » ('j') | src/property_changed_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698