Issue 5377005: Fixed port boundary check in test_server.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5377005: Fixed port boundary check in test_server.cc (Closed)

Created:
10 years ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
cbentzel

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixed port boundary check in test_server.cc BUG=53934 TEST=manual TBR=cbentzel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67487

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/test/test_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

akalin

9 years, 11 months ago (2011-01-12 19:24:31 UTC) #3

Yes, I think that's already done.

On Mon, Nov 29, 2010 at 9:50 AM,  <cbentzel@chromium.org> wrote:
> LGTM
>
> Do you need to make the same change to the XMPP port check?
>
> http://codereview.chromium.org/5377005/
>

Expand Messages | Collapse Messages