Issue 5374001: Move PasswordAutocompleteManagerTest tests out of anonymous namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5374001: Move PasswordAutocompleteManagerTest tests out of anonymous namespace (Closed)

Created:
10 years, 1 month ago by Ilya Sherman

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move PasswordAutocompleteManagerTest tests out of anonymous namespace BUG=none TEST=PasswordAutocompleteManagerTest.* (just refactoring code though) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68156

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/renderer/password_autocomplete_manager_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

Ignore the trybot runs shown here -- they're failing because LKGR was too old. I ...

10 years, 1 month ago (2010-11-24 12:07:56 UTC) #2

Jay Civelli

Hi, Sorry for the delay. Why do we need to take the tests out of ...

10 years ago (2010-12-01 17:26:13 UTC) #3

Ilya Sherman

On 2010/12/01 17:26:13, Jay Civelli wrote: > Why do we need to take the tests ...

10 years ago (2010-12-01 23:58:19 UTC) #4

Jay Civelli

10 years ago (2010-12-02 18:26:43 UTC) #5

OK, LGTM

On Wed, Dec 1, 2010 at 3:58 PM,  <isherman@chromium.org> wrote:
> On 2010/12/01 17:26:13, Jay Civelli wrote:
>>
>> Why do we need to take the tests out of the anonymous namespace?
>
> Not sure exactly, but see maruel's comments on
> http://codereview.chromium.org/3697009/
>
>
> http://codereview.chromium.org/5374001/
>

Expand Messages | Collapse Messages