Add testPartialUpdate, testCorruptedUpdate.

Add testPartialUpdate, testCorruptedUpdate.

Add two new tests that test update-engine handling of a corrupted image,
or a truncated image.

BUG=chromium-os:9502
TEST=Ran against Dell L13, Mario

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=969a673

[dgarrett, 2010-11-30 22:55:38]

This is the first half of the new tests. They depend on two canned images that
have been uploaded and made publicly available at the URL:

http://gsdview.appspot.com/chromeos-localmirror/autest-images/

Also, cros_au_test_harness will no longer output the results from
'image_to_live.sh' unless that script fails unexpectedly. This makes the output
much shorter and easier to go through.

[sosa, 2010-12-01 18:37:39]

Sweet, this looks nice.  Mostly nits

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py
File bin/cros_au_test_harness.py (right):

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:51: self.download = os.path.join(self.crosutilsbin,
'latest_download')
self.download_folder?

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:90: def UpdateImageReportError(self, image_path,
stateful_change='old'):
needs docstring .. may also want to make private

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:95: print err.stdout
Use warning?

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:115: def UpdatePayload(self, update_path,
stateful_change='old'):
Maybe UpdateUsingPayload

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:208: """Tests what happens if we attempt to update
with a truncated payload.
Only needs to be a one liner (i.e end triple quotes on same line)

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:211: self.UpdateImageReportError(target_image_path)
Move into PrepareBase and use PrepareBase (e.g. we don't actually have to do the
update for a VM image)

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:216: url =
'http://gsdview.appspot.com/chromeos-localmirror/autest-images/truncated_image.gz'
80 chars

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:220: shutil.copyfileobj(urllib.urlopen(url),
open(payload, 'w'))
Maybe use urllib.urlretrieve?

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:228: expectedMsg='download_hash_data ==
update_check_response_hash failed'
Might be easier to read with an expected regex rather than a nested try/except

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:231: print "Didn't find '%s' in:" % expectedMsg
Use Info or Warning

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:239: """Tests what happens if we attempt to update
with a corrupted payload.
Don't need a second line for docstring

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:242: self.UpdateImageReportError(target_image_path)
PrepareBase

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:247: url =
'http://gsdview.appspot.com/chromeos-localmirror/autest-images/corrupted_image.gz'
80 chars

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:261: expectedMsg='zlib inflate() error:-3'
expected_msg

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:269: unittest.fail('We managed to update with a
corrupted payload')
This code seems almost the same as the test before it.  May want to try to write
a common function that takes args i.e.

(payload, expected_msg, test_fail_message)

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:387: (code, stdout, stderr) =
RunCommandCaptureOutput([
Does this work for VM's?  The port isn't correct ... you'd need to use
cros_run_vm_update and pass payload through that

[dgarrett, 2010-12-02 22:20:19]

There were problems with these tests of VMs that are now fixed.

The other changes are just implementing the notes below.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py
File bin/cros_au_test_harness.py (right):

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:51: self.download = os.path.join(self.crosutilsbin,
'latest_download')
On 2010/12/01 18:37:39, sosa wrote:
> self.download_folder?

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:90: def UpdateImageReportError(self, image_path,
stateful_change='old'):
On 2010/12/01 18:37:39, sosa wrote:
> needs docstring .. may also want to make private

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:95: print err.stdout
On 2010/12/01 18:37:39, sosa wrote:
> Use warning?

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:115: def UpdatePayload(self, update_path,
stateful_change='old'):
On 2010/12/01 18:37:39, sosa wrote:
> Maybe UpdateUsingPayload

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:208: """Tests what happens if we attempt to update
with a truncated payload.
On 2010/12/01 18:37:39, sosa wrote:
> Only needs to be a one liner (i.e end triple quotes on same line)

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:216: url =
'http://gsdview.appspot.com/chromeos-localmirror/autest-images/truncated_image.gz'
On 2010/12/01 18:37:39, sosa wrote:
> 80 chars

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:220: shutil.copyfileobj(urllib.urlopen(url),
open(payload, 'w'))
On 2010/12/01 18:37:39, sosa wrote:
> Maybe use urllib.urlretrieve?

Nice, I looked for something like that, but missed it.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:231: print "Didn't find '%s' in:" % expectedMsg
On 2010/12/01 18:37:39, sosa wrote:
> Use Info or Warning

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:239: """Tests what happens if we attempt to update
with a corrupted payload.
On 2010/12/01 18:37:39, sosa wrote:
> Don't need a second line for docstring

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:242: self.UpdateImageReportError(target_image_path)
On 2010/12/01 18:37:39, sosa wrote:
> PrepareBase

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:247: url =
'http://gsdview.appspot.com/chromeos-localmirror/autest-images/corrupted_image.gz'
On 2010/12/01 18:37:39, sosa wrote:
> 80 chars

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:261: expectedMsg='zlib inflate() error:-3'
On 2010/12/01 18:37:39, sosa wrote:
> expected_msg

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:269: unittest.fail('We managed to update with a
corrupted payload')
On 2010/12/01 18:37:39, sosa wrote:
> This code seems almost the same as the test before it.  May want to try to
write
> a common function that takes args i.e.
> 
> (payload, expected_msg, test_fail_message)

Done.

http://codereview.chromium.org/5373008/diff/6001/bin/cros_au_test_harness.py#...
bin/cros_au_test_harness.py:387: (code, stdout, stderr) =
RunCommandCaptureOutput([
It did not, and the fix was larger than I was expecting.

On 2010/12/01 18:37:39, sosa wrote:
> Does this work for VM's?  The port isn't correct ... you'd need to use
> cros_run_vm_update and pass payload through that

[sosa, 2010-12-03 01:07:38]

LGTM w/ nit

http://codereview.chromium.org/5373008/diff/10001/bin/cros_au_test_harness.py
File bin/cros_au_test_harness.py (right):

http://codereview.chromium.org/5373008/diff/10001/bin/cros_au_test_harness.py...
bin/cros_au_test_harness.py:209: self.PrepareBase(base_image_path)
use image_path?