Issue 5372003: Display all of the CRL Distribution Point URIs in the Linux certificate viewer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5372003: Display all of the CRL Distribution Point URIs in the Linux certificate viewer (Closed)

Created:
10 years ago by Ryan Sleevi

Modified:
9 years, 7 months ago

Reviewers:
wtc, mattm

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

When viewing a certificate on Linux, if the certificate has a CRL Distribution Point extension, display all of the URIs contained, rather than only the first. BUG=64565 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68333

Patch Set 1 #

Patch Set 2 : Slight wording change #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

mattm: Would you take a look? I'm not sure how/where to add any appropriate unit ...

10 years ago (2010-11-28 11:08:19 UTC) #1

wtc

10 years ago (2010-11-29 20:03:07 UTC) #2

LGTM.

It's not necessary to update README.chromium because
we do not plan to merge our fork of these files with
the upstream.

Can you add a comment to note that 'generalName' is
a typo?  The 'fullName' choice member is a
GeneralNames.

Expand Messages | Collapse Messages