Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 5372002: Prevent redirects to non-HTTP URLs when fetching CRLs/OCSP responses (Closed)

Created:
10 years ago by Ryan Sleevi
Modified:
9 years, 7 months ago
Reviewers:
ukai, wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, agl
Visibility:
Public.

Description

When using NSS for certificate verification, add a check when fetching CRLs/OCSP responses to prevent redirects to non-HTTP URLs. This matches the initial check when first called from NSS to create the URLRequest. In particular, fetching a CRL/OCSP response over HTTPS is troublesome, as the certificate sent by the responder may also need revocation checking, potentially causing revocation checking loops. The existing check only considered the initial URL scheme supplied by NSS. However, if the server issues a redirect, the new URL scheme scheme was not filtered. BUG=64521 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M net/ocsp/nss_ocsp.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
ukai: Would you be willing to review this? Since you were responsible for most of ...
10 years ago (2010-11-28 09:06:59 UTC) #1
Ryan Sleevi
+cc agl: I didn't update http://crbug.com/64521 with the info yet. HTTP is disallowed for OCSP/CRL/AIAs ...
10 years ago (2010-11-29 16:34:27 UTC) #2
Ryan Sleevi
ukai: Ping?
10 years ago (2010-12-05 19:58:22 UTC) #3
ukai
LGTM
10 years ago (2010-12-06 01:07:50 UTC) #4
wtc
10 years ago (2010-12-08 20:07:13 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld 408576698