Move Mac LaunchOnStartup enable/disable to File thread

chrome/browser/background_mode_manager_mac.mm

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "app/l10n_util.h"
+#include "base/command_line.h"
+#include "base/mac_util.h"
+#include "chrome/app/chrome_command_ids.h"

[Andrew T Wilson (Slow), 2010/12/04 18:49:48]

can you remove chrome_command_ids.h?

[The wrong rickcam account, 2010/12/07 22:59:57]

Done.

+#include "chrome/browser/background_mode_manager.h"
+#include "chrome/browser/browser_thread.h"
+#include "chrome/common/app_mode_common_mac.h"
+#include "chrome/common/chrome_switches.h"
+#include "grit/generated_resources.h"
+
+class DisableLaunchOnStartupTask : public Task {
+ public:
+  virtual void Run();
+};
+
+class EnableLaunchOnStartupTask : public Task {
+ public:
+  virtual void Run();
+};
+
+const CFStringRef kLaunchOnStartupResetAllowedPrefsKey =
+    CFSTR("LaunchOnStartupResetAllowed");
+
+void DisableLaunchOnStartupTask::Run() {
+  Boolean keyExistsAndHasValidFormat;  // ignored

[Andrew T Wilson (Slow), 2010/12/04 18:49:48]

should be hacker_style, not camelCase?

[The wrong rickcam account, 2010/12/07 22:59:57]

Done.

+  if (CFPreferencesGetAppBooleanValue(kLaunchOnStartupResetAllowedPrefsKey,

[Andrew T Wilson (Slow), 2010/12/04 18:49:48]

I did some quick googling, and I didn't see anything that implies that these
CFPreferences APIs are thread safe, so I'm not positive it's OK to call them
from the file thread. I'd want you to run this by some of the mac folks
(pinkerton?) first - maybe we just want to make a new rule that these APIs can
only be called from the FILE thread, and create a wrapper function in mac_util
that ensures that the right thread is being used.

Failing that, I don't think it's the end of the world to send a message back to
the UI thread to set the "launchonstartupresetallowed" value in the profile
preferences.

Also, "Hey, aren't you inverting the sense of this check here?" :)

[The wrong rickcam account, 2010/12/07 22:59:57]

I've fixed the inverted test.

Based on email from avi@ affirming that they are thread-safe, and further
discussion with you about our options, I will leave this code using
CFPreferences in place.

+                                      app_mode::kAppPrefsID,
+                                      &keyExistsAndHasValidFormat))
+    return;
+
+  CFPreferencesSetAppValue(kLaunchOnStartupResetAllowedPrefsKey,
+                           kCFBooleanFalse,
+                           app_mode::kAppPrefsID);
+
+  // Check if Chrome is not a login Item, or is a Login Item but w/o 'hidden'
+  // flag - most likely user has modified the setting, don't override it.
+  bool is_hidden = false;
+  if (!mac_util::CheckLoginItemStatus(&is_hidden) || !is_hidden)
+    return;
+
+  mac_util::RemoveFromLoginItems();
+}
+
+void EnableLaunchOnStartupTask::Run() {
+  // Return if Chrome is already a Login Item (avoid overriding user choice).
+  if (mac_util::CheckLoginItemStatus(NULL))
+    return;
+
+  mac_util::AddToLoginItems(true);  // Hide on startup.
+  CFPreferencesSetAppValue(kLaunchOnStartupResetAllowedPrefsKey,
+                           kCFBooleanTrue,
+                           app_mode::kAppPrefsID);
+}
+
+void BackgroundModeManager::EnableLaunchOnStartup(bool should_launch) {
+  // This functionality is only defined for default profile, currently.
+  if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kUserDataDir))
+    return;
+
+  if (should_launch) {
+    BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
+                            new EnableLaunchOnStartupTask());
+  } else {
+    BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
+                            new DisableLaunchOnStartupTask());
+  }
+}
+
+string16 BackgroundModeManager::GetPreferencesMenuLabel() {
+  return l10n_util::GetStringUTF16(IDS_OPTIONS);
+}