chrome/browser/background_mode_manager_chromeos.cc - Issue 5368002: Move Mac LaunchOnStartup enable/disable to File thread

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/background_mode_manager_chromeos.cc

Issue 5368002: Move Mac LaunchOnStartup enable/disable to File thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changing Mac LaunchOnStartupResetAllowed to accommodate FILE thread issues Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/background_mode_manager.h ('K') | « chrome/browser/background_mode_manager.cc ('k') | chrome/browser/background_mode_manager_linux.cc » ('j') | chrome/browser/background_mode_manager_linux.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/background_mode_manager.h"

	6 #include "grit/generated_resources.h"
	Andrew T Wilson (Slow) 2010/12/04 18:49:48 Blank line between "#include 'chrome/browser/backg Blank line between "#include 'chrome/browser/background_mode_manager.h" and other includes. The wrong rickcam account 2010/12/07 22:59:57 Done. Show quoted text On 2010/12/04 18:49:48, Andrew T Wilson wrote: > Blank line between "#include 'chrome/browser/background_mode_manager.h" and > other includes. Done.
	7

	8 void BackgroundModeManager::EnableLaunchOnStartup(bool should_launch) {
	Andrew T Wilson (Slow) 2010/12/04 18:49:48 I'm torn about whether we should put a NOT_REACHED I'm torn about whether we should put a NOT_REACHED in here. The wrong rickcam account 2010/12/07 22:59:57 Done. I thought about it and decided against with Show quoted text On 2010/12/04 18:49:48, Andrew T Wilson wrote: > I'm torn about whether we should put a NOT_REACHED in here. Done. I thought about it and decided against with the idea that it would put (unnecessary??) burden on BackgroundModeManager to avoid calling EnableLaunchOnStartup at all. Now that we've dug in a bit more on the details of NOTREACHED -- it's a DCHECK -- I'm going to say that Yes, we should add it here.
	9 }

	10

	11 string16 BackgroundModeManager::GetPreferencesMenuLabel() {

	12 return l10n_util::GetStringUTF16(IDS_SETTINGS);

	13 }

OLD	NEW