chrome/browser/background_mode_manager_chromeos.cc - Issue 5368002: Move Mac LaunchOnStartup enable/disable to File thread

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/background_mode_manager_chromeos.cc

Issue 5368002: Move Mac LaunchOnStartup enable/disable to File thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Eliminating excess header includes: Windows Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "app/menus/simple_menu_model.h"

	6 #include "chrome/browser/background_mode_manager.h"

	7 #include "grit/generated_resources.h"

	8

	9 void BackgroundModeManager::DisableLaunchOnStartupTask::Run() {

	10 }
	Andrew T Wilson (Slow) 2010/12/03 02:06:59 This code should never be called, so we should put This code should never be called, so we should put NOTREACHED() calls in all these APIs. See also my previous note about not having Task objects at all on chromeos. The wrong rickcam account 2010/12/04 02:08:04 Done. Eliminate this routine outright a la your p Show quoted text On 2010/12/03 02:06:59, Andrew T Wilson wrote: > This code should never be called, so we should put NOTREACHED() calls in all > these APIs. See also my previous note about not having Task objects at all on > chromeos. Done. Eliminate this routine outright a la your previous note.
	11

	12 void BackgroundModeManager::EnableLaunchOnStartupTask::Run() {

	13 }

	14

	15 void BackgroundModeManager::AddPreferencesItem(menus::SimpleMenuModel* menu) {

	16 menu->AddItemWithStringId(IDC_OPTIONS, IDS_SETTINGS);

	17 }

OLD	NEW