Issue 5367006: Refactor: move HostContentSettingsMap to content_settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5367006: Refactor: move HostContentSettingsMap to content_settings (Closed)

Created:
10 years ago by gfeher

Modified:
9 years, 7 months ago

Reviewers:
markusheintz_, jochen (gone - plz use gerrit)

CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, jam, kinuko, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Refactor: move HostContentSettingsMap to content_settings BUG=64660 TEST=build succeeds (no effective code change) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67706

Patch Set 1 #

Patch Set 2 : add missing files #

Patch Set 3 : " #

Patch Set 4 : " #

Patch Set 5 : " #

Patch Set 6 : rebaee before commit #

Patch Set 7 : rebase again #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -48 lines)			Patch
M	chrome/browser/appcache/chrome_appcache_service.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	1 2 3 4 5	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/content_exceptions_window_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/content_setting_bubble_cocoa.mm	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/content_settings_dialog_controller.mm	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/simple_content_exceptions_window_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_exceptions_table_model.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_exceptions_table_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_setting_bubble_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_setting_bubble_model_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_setting_image_model.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_setting_image_model_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/content_settings/host_content_settings_map.h	View	1 2 3 4 5	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/content_settings/host_content_settings_map.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	chrome/browser/content_settings/host_content_settings_map_unittest.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cookies_tree_model_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/options/content_settings_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/file_system/file_system_dispatcher_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/content_setting_bubble_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/options/content_exception_editor.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/options/content_filter_page_gtk.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/options/cookie_filter_page_gtk.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/options/cookie_filter_page_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/in_process_webkit/dom_storage_area.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/chrome_cookie_policy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/chrome_url_request_context.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/cookie_policy_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/options_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_exceptions_table_model.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/profile_impl.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/database_dispatcher_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 2 3 4 5	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/content_setting_bubble_contents.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/options/content_filter_page_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/options/cookie_filter_page_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/options/exception_editor_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/worker_host/worker_process_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/worker_host/worker_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/test/testing_profile.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gfeher

Do we have a bug number that would put this into context? Please review.

10 years ago (2010-11-29 17:59:54 UTC) #1

jochen (gone - plz use gerrit)

please create a meta bug and block it on 63656 lgtm

10 years ago (2010-11-29 18:05:02 UTC) #2

LGTM

Expand Messages | Collapse Messages