Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 5366004: [cros] Make sure that update screen will be skipped when shortcut is pressed. (Closed)

Created:
10 years ago by Nikita (slow)
Modified:
9 years, 7 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[cros] Make sure that update screen will be skipped when shortcut is pressed. Converted some important logging to LOG(INFO). See similar CL to branch http://codereview.chromium.org/5291010/ Had to make 2 copies because update_screen.cc has been changed in trunk. BUG=chromium-os:9654 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M chrome/browser/chromeos/login/update_screen.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/update_screen.cc View 6 chunks +23 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nikita (slow)
10 years ago (2010-11-30 17:18:15 UTC) #1
Dmitry Polukhin
LGTM
10 years ago (2010-11-30 17:21:06 UTC) #2
Dmitry Polukhin
10 years ago (2010-11-30 17:23:44 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698