Issue 5364007: Autofill should not allow overwrite of field data when merging profile data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5364007: Autofill should not allow overwrite of field data when merging profile data (Closed)

Created:
10 years ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, James Hawkins, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Autofill should not allow overwrite of field data when merging profile data Changes notion of |PrimaryKey| to include address line 2 and email. When submitting a filled form the Autofill merging of profiles now considers changes to address line 2 and email a trigger to create a new profile. BUG=64669 TEST=PersonalDataManagerTest.AggregateSameProfileWithConflict Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67680

Patch Set 1 #

Total comments: 2

Patch Set 2 : Whitespace. #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -7 lines)			Patch
	M	chrome/browser/autofill/autofill_profile.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/autofill/personal_data_manager_unittest.cc	View	1	4 chunks	+19 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM, thanks http://codereview.chromium.org/5364007/diff/1/chrome/browser/autofill/personal_data_manager_unittest.cc File chrome/browser/autofill/personal_data_manager_unittest.cc (right): http://codereview.chromium.org/5364007/diff/1/chrome/browser/autofill/personal_data_manager_unittest.cc#newcode776 chrome/browser/autofill/personal_data_manager_unittest.cc:776: "Washington", "theprez@gmail.com", NULL, "1600 Pennsylvania Avenue", nit: ...

10 years ago (2010-11-30 01:18:50 UTC) #2

dhollowa

10 years ago (2010-11-30 01:31:27 UTC) #3

http://codereview.chromium.org/5364007/diff/1/chrome/browser/autofill/persona...
File chrome/browser/autofill/personal_data_manager_unittest.cc (right):

http://codereview.chromium.org/5364007/diff/1/chrome/browser/autofill/persona...
chrome/browser/autofill/personal_data_manager_unittest.cc:776: "Washington",
"theprez@gmail.com", NULL, "1600 Pennsylvania Avenue",
On 2010/11/30 01:18:50, Ilya Sherman wrote:
> nit: There's a space at the end of this line (thanks, git cl patch!)

Done.  In this case the GTM Plugin failed me... somehow it got turned off.

Expand Messages | Collapse Messages