Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 5364003: Make URLRequestThrottlerEntryInterface inherit RefCountedThreadSafe, (Closed)

Created:
10 years ago by Jói
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, yzshen
Visibility:
Public.

Description

Make URLRequestThrottlerEntryInterface inherit RefCountedThreadSafe, as a quick fix for bug 64501. yzshen is planning to refactor these classes significantly, so I won't make a bigger change at this point (e.g. to prevent use of the interface on different threads). BUG=64501 TEST=ThreadSanitizer complains no more. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67471

Patch Set 1 #

Patch Set 2 : Remove suppression. #

Patch Set 3 : Add friend. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M net/url_request/url_request_throttler_entry_interface.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M tools/valgrind/tsan/suppressions.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jói
10 years ago (2010-11-26 17:31:13 UTC) #1
Sigurður Ásgeirsson
lgtm.
10 years ago (2010-11-26 18:10:44 UTC) #2
Jói
FYI, I added the friend statement we talked about to make it compile. Will commit ...
10 years ago (2010-11-26 18:39:06 UTC) #3
yzshen
Hi, Joi. Thanks for fixing the issue! On Fri, Nov 26, 2010 at 10:38 AM, ...
10 years ago (2010-11-26 20:39:35 UTC) #4
Jói
No problem. It's not checked in yet, but will be soon, waiting on a couple ...
10 years ago (2010-11-26 20:45:45 UTC) #5
yzshen
10 years ago (2010-11-26 20:57:37 UTC) #6
Hi, Joi.

On Fri, Nov 26, 2010 at 12:45 PM, Jói Sigurðsson <joi@chromium.org> wrote:

> No problem. It's not checked in yet, but will be soon, waiting on a
> couple more trybots.
>
> Yuzhu, when you go through your refactoring, I think one of the things
> Will had suggested you look at was removing the use of refcounting, so
> I made the current change very minimal. I will close the bug once I
> commit, but please keep it in mind as you refactor.
>
 Sure. I will keep this in mind. :)

>
> Cheers,
> Jói
>
>
>
> 2010/11/26 Yuzhu Shen <yzshen@google.com>:
> > Hi, Joi.
> > Thanks for fixing the issue!
> >
> > On Fri, Nov 26, 2010 at 10:38 AM, Jói Sigurðsson <joi@chromium.org>
> wrote:
> >>
> >> FYI, I added the friend statement we talked about to make it compile.
> >> Will commit once trybots say it's all good.
> >>
> >> On Fri, Nov 26, 2010 at 1:10 PM,  <siggi@chromium.org> wrote:
> >> > lgtm.
> >> >
> >> > http://codereview.chromium.org/5364003/
> >> >
> >
> >
> >
> > --
> > Best regards,
> > Yuzhu Shen.
> >
> >
>



-- 
Best regards,
Yuzhu Shen.

Powered by Google App Engine
This is Rietveld 408576698