Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 5364002: Add pyauto tests for Web SQL databases. (Closed)

Created:
10 years, 1 month ago by kkania
Modified:
9 years, 7 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., Nirnimesh
Visibility:
Public.

Description

Add pyauto tests for Web SQL databases. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68263

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix kill test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -18 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 1 chunk +2 lines, -0 lines 1 comment Download
M chrome/test/functional/databases.py View 1 5 chunks +47 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kkania
Here are a couple of tests from the testers.
10 years, 1 month ago (2010-11-24 18:30:10 UTC) #1
Nirnimesh
http://codereview.chromium.org/5364002/diff/1/chrome/test/functional/databases.py File chrome/test/functional/databases.py (right): http://codereview.chromium.org/5364002/diff/1/chrome/test/functional/databases.py#newcode277 chrome/test/functional/databases.py:277: self.NavigateToURL('about:crash') This will create a .dmp file, and there're ...
10 years, 1 month ago (2010-11-24 23:07:57 UTC) #2
kkania
10 years ago (2010-11-30 00:13:47 UTC) #3
Nirnimesh
10 years ago (2010-11-30 01:08:15 UTC) #4
LGTM

http://codereview.chromium.org/5364002/diff/5001/chrome/test/functional/PYAUT...
File chrome/test/functional/PYAUTO_TESTS (right):

http://codereview.chromium.org/5364002/diff/5001/chrome/test/functional/PYAUT...
chrome/test/functional/PYAUTO_TESTS:34: # Reloading after kill doesn't load the
page, crbug.com/64708.
Are you sure?
testReloadActiveTab seems to work fine.

Powered by Google App Engine
This is Rietveld 408576698