Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: media/base/pipeline_impl.h

Issue 5362003: Stopgap fix for crash in issue 53867 comment 15 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | media/base/pipeline_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Implementation of Pipeline. 5 // Implementation of Pipeline.
6 6
7 #ifndef MEDIA_BASE_PIPELINE_IMPL_H_ 7 #ifndef MEDIA_BASE_PIPELINE_IMPL_H_
8 #define MEDIA_BASE_PIPELINE_IMPL_H_ 8 #define MEDIA_BASE_PIPELINE_IMPL_H_
9 9
10 #include <set> 10 #include <set>
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 // appropriate callbacks, and setting the appropriate pipeline state 227 // appropriate callbacks, and setting the appropriate pipeline state
228 // depending on whether we performing Stop() or SetError(). 228 // depending on whether we performing Stop() or SetError().
229 // Called after all filters have been stopped. 229 // Called after all filters have been stopped.
230 void FinishDestroyingFiltersTask(); 230 void FinishDestroyingFiltersTask();
231 231
232 // Internal methods used in the implementation of the pipeline thread. All 232 // Internal methods used in the implementation of the pipeline thread. All
233 // of these methods are only called on the pipeline thread. 233 // of these methods are only called on the pipeline thread.
234 234
235 // PrepareFilter() creates the filter's thread and injects a FilterHost and 235 // PrepareFilter() creates the filter's thread and injects a FilterHost and
236 // MessageLoop. 236 // MessageLoop.
237 void PrepareFilter(scoped_refptr<MediaFilter> filter); 237 bool PrepareFilter(scoped_refptr<MediaFilter> filter);
238 238
239 // The following initialize methods are used to select a specific type of 239 // The following initialize methods are used to select a specific type of
240 // MediaFilter object from MediaFilterCollection and initialize it 240 // MediaFilter object from MediaFilterCollection and initialize it
241 // asynchronously. 241 // asynchronously.
242 void InitializeDataSource(); 242 void InitializeDataSource();
243 void InitializeDemuxer(const scoped_refptr<DataSource>& data_source); 243 void InitializeDemuxer(const scoped_refptr<DataSource>& data_source);
244 244
245 // Returns true if the asynchronous action of creating decoder has started. 245 // Returns true if the asynchronous action of creating decoder has started.
246 // Returns false if this method did nothing because the corresponding 246 // Returns false if this method did nothing because the corresponding
247 // audio/video stream does not exist. 247 // audio/video stream does not exist.
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 417
418 FRIEND_TEST_ALL_PREFIXES(PipelineImplTest, GetBufferedTime); 418 FRIEND_TEST_ALL_PREFIXES(PipelineImplTest, GetBufferedTime);
419 FRIEND_TEST_ALL_PREFIXES(PipelineImplTest, AudioStreamShorterThanVideo); 419 FRIEND_TEST_ALL_PREFIXES(PipelineImplTest, AudioStreamShorterThanVideo);
420 420
421 DISALLOW_COPY_AND_ASSIGN(PipelineImpl); 421 DISALLOW_COPY_AND_ASSIGN(PipelineImpl);
422 }; 422 };
423 423
424 } // namespace media 424 } // namespace media
425 425
426 #endif // MEDIA_BASE_PIPELINE_IMPL_H_ 426 #endif // MEDIA_BASE_PIPELINE_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | media/base/pipeline_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698