Issue 5361006: For OSX, make it so that notifications only start resizing after the first paint is done.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5361006: For OSX, make it so that notifications only start resizing after the first paint is done. (Closed)

Created:
10 years ago by levin

Modified:
9 years, 7 months ago

Reviewers:
John Gregg

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser

Visibility:
Public.

Description

For OSX, make it so that notifications only start resizing after the first paint is done. Also, only allow them to grow. A later fix will remove this ifdef replacing it with code that works across platforms. BUG=56693 TEST=Ran many tests manually. Automated test in progress (before closing the bug). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67673

Patch Set 1 #

Patch Set 2 : fix lint warning #

Patch Set 3 : Fix ifdef. #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -2 lines)			Patch
M	chrome/browser/notifications/balloon.cc	View		2 chunks	+13 lines, -1 line	1 comment	Download
M	chrome/browser/notifications/balloon_host.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_host.cc	View	1 2	4 chunks	+38 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Gregg

10 years ago (2010-11-30 00:25:22 UTC) #2

LGTM after suggested change

http://codereview.chromium.org/5361006/diff/2002/chrome/browser/notifications...
File chrome/browser/notifications/balloon.cc (right):

http://codereview.chromium.org/5361006/diff/2002/chrome/browser/notifications...
chrome/browser/notifications/balloon.cc:32: #if defined(OS_MACOSX)
add comment with a TODO and bug # about making this cross-platform

Expand Messages | Collapse Messages