Issue 5361001: Add the views unittests to the windows buildbot target to make sure...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5361001: Add the views unittests to the windows buildbot target to make sure... (Closed)

Created:
10 years ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
chase

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add the views unittests to the windows buildbot target to make sure it is available on the slaves. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67217

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/all.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

chase

10 years ago (2010-11-23 21:55:33 UTC) #2

lgtm, but there's a GYP error in the try bot run:

KeyError: 'src\\views\\views.gyp:views_unittests#target while trying to load
target src\\build\\all.gyp:chromium_builder_tests#target'

Are you sure views_unittests exists?  I don't see it in src/views/views.gyp.

Expand Messages | Collapse Messages