Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 536089: Support backtrace debug command when stack is empty (Closed)

Created:
10 years, 11 months ago by Peter Rybin
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Support backtrace debug command when stack is empty Committed: http://code.google.com/p/v8/source/detail?r=3663

Patch Set 1 #

Patch Set 2 : rollback some #

Patch Set 3 : add test #

Patch Set 4 : complete test #

Patch Set 5 : rollback test #

Patch Set 6 : test added #

Patch Set 7 : rollback main change #

Total comments: 2

Patch Set 8 : atoi -> strtol #

Patch Set 9 : clean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M test/cctest/test-debug.cc View 3 4 6 7 8 2 chunks +69 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Rybin
Hi Søren I'd like to support "suspend" command when in Debug::ProcessDebugMessages, i.e. when stack is ...
10 years, 11 months ago (2010-01-16 23:44:41 UTC) #1
Søren Thygesen Gjesse
LGTM Please add a test sending a backtrace request with an empty stack.
10 years, 11 months ago (2010-01-18 10:09:56 UTC) #2
Peter Rybin
On 2010/01/18 10:09:56, Søren Gjesse wrote: > LGTM > > Please add a test sending ...
10 years, 11 months ago (2010-01-19 22:41:28 UTC) #3
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/536089/diff/8001/4002 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/536089/diff/8001/4002#newcode5874 test/cctest/test-debug.cc:5874: BracktraceData::frame_counter = -10; Why not just -1?
10 years, 11 months ago (2010-01-20 09:44:36 UTC) #4
Peter Rybin
10 years, 11 months ago (2010-01-20 16:32:24 UTC) #5
http://codereview.chromium.org/536089/diff/8001/4002
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/536089/diff/8001/4002#newcode5874
test/cctest/test-debug.cc:5874: BracktraceData::frame_counter = -10;
On 2010/01/20 09:44:36, Søren Gjesse wrote:
> Why not just -1?

I expect atoi to return "-1" if number wasn't parsed. So I to put different
magic number here (i.e. -10).

Powered by Google App Engine
This is Rietveld 408576698