Mac: Save/restore task manager window pos and size.

Mac: Save/restore task manager window pos and size.

Make window size remembering mechanism easier to use and more compatible with windows's chrome profiles.

Nib changes: Unset "show at startup" so that the initial repositioning isn't visible.

BUG=32147
TEST=Move & size taskman window, quit chrome, reopen chrome. Size & pos should've stayed. Same for keyword editor. Page info dialog should behave as it did before.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36557

[Robert Sesek, 2010-01-19 16:00:03]

http://codereview.chromium.org/536086/diff/6003/6004
File chrome/app/nibs/KeywordEditor.xib (right):

http://codereview.chromium.org/536086/diff/6003/6004#newcode45
chrome/app/nibs/KeywordEditor.xib:45: <string
key="NSWindowContentMaxSize">{3.40282e+38, 3.40282e+38}</string>
It looks like you only changed the NSWindowContentMaxSize? If so, can you
unstage all the other changes (make the XIB diff as minimal as possible). Also,
please list the XIB changes in the CL description.

http://codereview.chromium.org/536086/diff/6003/6005
File chrome/app/nibs/PageInfo.xib (right):

http://codereview.chromium.org/536086/diff/6003/6005#newcode1
chrome/app/nibs/PageInfo.xib:1: <?xml version="1.0" encoding="UTF-8"?>
What changed here?

http://codereview.chromium.org/536086/diff/6003/6017
File chrome/browser/cocoa/window_size_autosaver.h (right):

http://codereview.chromium.org/536086/diff/6003/6017#newcode3
chrome/browser/cocoa/window_size_autosaver.h:3: // found in the LICENSE file.
Blank line after this.

http://codereview.chromium.org/536086/diff/6003/6017#newcode11
chrome/browser/cocoa/window_size_autosaver.h:11: kSaveWindowPos,
Comment both of these enum values and indent them.

http://codereview.chromium.org/536086/diff/6003/6017#newcode15
chrome/browser/cocoa/window_size_autosaver.h:15: @interface WindowSizeAutosaver
: NSObject {
Class level comment.

http://codereview.chromium.org/536086/diff/6003/6017#newcode16
chrome/browser/cocoa/window_size_autosaver.h:16: NSWindow* window_;  // strong
or weak?
Weak. The WindowController will outlive the Autosaver, which means the window
should too.

[Nico, 2010-01-19 21:32:49]

http://codereview.chromium.org/536086/diff/6003/6004
File chrome/app/nibs/KeywordEditor.xib (right):

http://codereview.chromium.org/536086/diff/6003/6004#newcode45
chrome/app/nibs/KeywordEditor.xib:45: <string
key="NSWindowContentMaxSize">{3.40282e+38, 3.40282e+38}</string>
On 2010/01/19 16:00:03, rsesek wrote:
> It looks like you only changed the NSWindowContentMaxSize? If so, can you
> unstage all the other changes (make the XIB diff as minimal as possible).
Also,
> please list the XIB changes in the CL description.

The XIB changes are listed in the CL description ("Nib changes: Unset "show at
startup" so that the initial repositioning isn't visible.").

I only clicked a single checkbox and saved in IB and got this diff. I just did

git checkout trunk chrome/app/nib/KeywordEditor.xib
open c/a/n/K.xib
# click "visible at launch" checkbox
# save
git diff trunk c/a/n/K.xib

to make sure and it produced the same diff.

As far as I know, the IB version I use is what's the currently recommended
version is. Someone must've used a different version to originally create this
file :-)

http://codereview.chromium.org/536086/diff/6003/6005
File chrome/app/nibs/PageInfo.xib (right):

http://codereview.chromium.org/536086/diff/6003/6005#newcode1
chrome/app/nibs/PageInfo.xib:1: <?xml version="1.0" encoding="UTF-8"?>
On 2010/01/19 16:00:03, rsesek wrote:
> What changed here?

See last comment.

http://codereview.chromium.org/536086/diff/6003/6017
File chrome/browser/cocoa/window_size_autosaver.h (right):

http://codereview.chromium.org/536086/diff/6003/6017#newcode3
chrome/browser/cocoa/window_size_autosaver.h:3: // found in the LICENSE file.
On 2010/01/19 16:00:03, rsesek wrote:
> Blank line after this.

Done.

http://codereview.chromium.org/536086/diff/6003/6017#newcode11
chrome/browser/cocoa/window_size_autosaver.h:11: kSaveWindowPos,
On 2010/01/19 16:00:03, rsesek wrote:
> Comment both of these enum values and indent them.

Done.

http://codereview.chromium.org/536086/diff/6003/6017#newcode15
chrome/browser/cocoa/window_size_autosaver.h:15: @interface WindowSizeAutosaver
: NSObject {
On 2010/01/19 16:00:03, rsesek wrote:
> Class level comment.

Done.

http://codereview.chromium.org/536086/diff/6003/6017#newcode16
chrome/browser/cocoa/window_size_autosaver.h:16: NSWindow* window_;  // strong
or weak?
On 2010/01/19 16:00:03, rsesek wrote:
> Weak. The WindowController will outlive the Autosaver, which means the window
> should too.

Done.

[Robert Sesek, 2010-01-19 21:51:12]

LGTM, provided a Mac trybot goes green.

http://codereview.chromium.org/536086/diff/6003/6004
File chrome/app/nibs/KeywordEditor.xib (right):

http://codereview.chromium.org/536086/diff/6003/6004#newcode45
chrome/app/nibs/KeywordEditor.xib:45: <string
key="NSWindowContentMaxSize">{3.40282e+38, 3.40282e+38}</string>
On 2010/01/19 21:32:49, Nico wrote:
> On 2010/01/19 16:00:03, rsesek wrote:
> > It looks like you only changed the NSWindowContentMaxSize? If so, can you
> > unstage all the other changes (make the XIB diff as minimal as possible).
> Also,
> > please list the XIB changes in the CL description.
> 
> The XIB changes are listed in the CL description ("Nib changes: Unset "show at
> startup" so that the initial repositioning isn't visible.").
> 
> I only clicked a single checkbox and saved in IB and got this diff. I just did
> 
> git checkout trunk chrome/app/nib/KeywordEditor.xib
> open c/a/n/K.xib
> # click "visible at launch" checkbox
> # save
> git diff trunk c/a/n/K.xib
> 
> to make sure and it produced the same diff.
> 
> As far as I know, the IB version I use is what's the currently recommended
> version is. Someone must've used a different version to originally create this
> file :-)

Fair enough ;-).

http://codereview.chromium.org/536086/diff/5039/6035
File chrome/browser/cocoa/window_size_autosaver.h (right):

http://codereview.chromium.org/536086/diff/5039/6035#newcode27
chrome/browser/cocoa/window_size_autosaver.h:27: // restored when the
autosaver's |initWithWindow:...| method is called.
Maybe add a note about not having "Visible on launched" checked?