Rework run_autotest.sh to support server side control files.

Rework run_autotest.sh to support server side control files.

The idea here is to remove flag processing inside this wrapper script and pass on all flags into autoserv.

I've tested with server/site_tests/system_BootPerfServer and a client side tests.

Both work fine.

[petkov, 2010-01-15 21:38:24]

I'm confused about the usefulness of this script at this point. Maybe we could
have a separate script that starts ssh-agent, if necessary, and adds the key. Or
just require that the key is added in order to run autotest and remove this
script completely.

http://codereview.chromium.org/536081/diff/3001/3002
File src/scripts/run_autotest.sh (right):

http://codereview.chromium.org/536081/diff/3001/3002#newcode18
src/scripts/run_autotest.sh:18:
AUTOTEST_SRC="${GCLIENT_ROOT}/src/third_party/autotest/files"
This variable is not necessary.

http://codereview.chromium.org/536081/diff/3001/3002#newcode46
src/scripts/run_autotest.sh:46: pushd ${AUTOTEST_CHROOT_DEST} 1> /dev/null
Hmm, this comes from a different change but isn't this going to cause a problem
with control files specified as relative paths?

[ericli, 2010-01-15 21:51:39]

I think this script is useful, so people dont need to do an extra
step to setup ssh-agent and add keys. Otherwise we had to document it and people
need to do it time by time.

An alternative approach would be to include ssh-agent and key adding into
enter_chroot.sh script?



On 2010/01/15 21:38:24, petkov wrote:
> I'm confused about the usefulness of this script at this point. Maybe we could
> have a separate script that starts ssh-agent, if necessary, and adds the key.
Or
> just require that the key is added in order to run autotest and remove this
> script completely.
> 
> http://codereview.chromium.org/536081/diff/3001/3002
> File src/scripts/run_autotest.sh (right):
> 
> http://codereview.chromium.org/536081/diff/3001/3002#newcode18
> src/scripts/run_autotest.sh:18:
> AUTOTEST_SRC="${GCLIENT_ROOT}/src/third_party/autotest/files"
> This variable is not necessary.
> 
> http://codereview.chromium.org/536081/diff/3001/3002#newcode46
> src/scripts/run_autotest.sh:46: pushd ${AUTOTEST_CHROOT_DEST} 1> /dev/null
> Hmm, this comes from a different change but isn't this going to cause a
problem
> with control files specified as relative paths?

[ericli, 2010-01-15 23:19:03]

Darin,
Please take another look.

http://codereview.chromium.org/536081/diff/3001/3002
File src/scripts/run_autotest.sh (right):

http://codereview.chromium.org/536081/diff/3001/3002#newcode18
src/scripts/run_autotest.sh:18:
AUTOTEST_SRC="${GCLIENT_ROOT}/src/third_party/autotest/files"
On 2010/01/15 21:38:24, petkov wrote:
> This variable is not necessary.
> 

Done.

http://codereview.chromium.org/536081/diff/3001/3002#newcode46
src/scripts/run_autotest.sh:46: pushd ${AUTOTEST_CHROOT_DEST} 1> /dev/null
I guess we should always specify control file path as relative to AUTOTEST_ROOT?

I've update the how-to doc about that.


On 2010/01/15 21:38:24, petkov wrote:
> Hmm, this comes from a different change but isn't this going to cause a
problem
> with control files specified as relative paths?
>

[petkov, 2010-01-15 23:27:36]

LGTM because the issue exists in the previous revision too so no need to fix
with this CL. Document that an absolute path needs to be used. This needs to be
cleaned up.