Issue 536077: Implement enough of the partial snapshots that we can deserialize...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 536077: Implement enough of the partial snapshots that we can deserialize... (Closed)

Created:
10 years, 11 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Implement enough of the partial snapshots that we can deserialize a single string. Committed: http://code.google.com/p/v8/source/detail?r=3619

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -9 lines)			Patch
M	src/serialize.h	View	4 chunks	+9 lines, -2 lines	0 comments	Download
M	src/serialize.cc	View	5 chunks	+30 lines, -6 lines	0 comments	Download
M	src/v8.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View	4 chunks	+74 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 11 months ago (2010-01-15 14:11:22 UTC) #2

LGTM

http://codereview.chromium.org/536077/diff/1/2
File test/cctest/test-serialize.cc (right):

http://codereview.chromium.org/536077/diff/1/2#newcode371
test/cctest/test-serialize.cc:371: int new_size, pointer_size, data_size,
code_size, map_size, cell_size, large_size;
Line length.

Expand Messages | Collapse Messages