Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 536065: Optimized calling of C++ builtins (and HandleApiCall (Closed)

Created:
10 years, 11 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Optimized calling of C++ builtins (and HandleApiCall in particular). * Called function is passed on the stack instead of using a static variable. * Builtins that don't need the called function don't get it. * Made is_construct statically known to HandleApiCall by setting custom construct stub for API functions. Committed: http://code.google.com/p/v8/source/detail?r=3613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -142 lines) Patch
M src/arm/builtins-arm.cc View 4 chunks +49 lines, -12 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/builtins.h View 6 chunks +29 lines, -19 lines 0 comments Download
M src/builtins.cc View 19 chunks +128 lines, -65 lines 0 comments Download
M src/factory.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 4 chunks +53 lines, -12 lines 0 comments Download
M src/serialize.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M src/x64/builtins-x64.cc View 4 chunks +53 lines, -13 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
10 years, 11 months ago (2010-01-14 21:50:09 UTC) #1
Mads Ager (chromium)
10 years, 11 months ago (2010-01-15 08:19:31 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698