Fix a problem with const initialization in the top-level code generator....

Fix a problem with const initialization in the top-level code generator.

When initializing the special local variable containing the reference to the enclosing 
function in named functions we now (correctly) emit an INIT_CONST instead of INIT_VAR,
and we correctly bail out in the top-level code generator.

Also part of this change is adding missing statement position information 
for some statements in the top-level code generator.


Committed: http://code.google.com/p/v8/source/detail?r=3587

[Kevin Millikin (Chromium), 2010-01-12 16:32:25]

LGTM once it passes all tests on the ARM simulator too.

http://codereview.chromium.org/536029/diff/1/3
File src/codegen.cc (right):

http://codereview.chromium.org/536029/diff/1/3#newcode290
src/codegen.cc:290: StoreToSlot(scope_->function()->slot(), NOT_CONST_INIT);
As we discussed, this won't work on ARM.  There is no StoreToSlot there.

I'd move it into the platform specific CodeGenerator::GenCode functions (just
before calling CodeGenerator::ProcessDeclarations).

[fschneider, 2010-01-12 17:16:03]

http://codereview.chromium.org/536029/diff/1/3
File src/codegen.cc (right):

http://codereview.chromium.org/536029/diff/1/3#newcode290
src/codegen.cc:290: StoreToSlot(scope_->function()->slot(), NOT_CONST_INIT);
On 2010/01/12 16:32:25, Kevin Millikin wrote:
> As we discussed, this won't work on ARM.  There is no StoreToSlot there.
> 
> I'd move it into the platform specific CodeGenerator::GenCode functions (just
> before calling CodeGenerator::ProcessDeclarations).

Done.