Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 536010: Fix wrong assert in compare stub minor key computation. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6545 matching lines...) Expand 10 before | Expand all | Expand 10 after
6556 } 6556 }
6557 } 6557 }
6558 } 6558 }
6559 default: return "CompareStub"; 6559 default: return "CompareStub";
6560 } 6560 }
6561 } 6561 }
6562 6562
6563 6563
6564 int CompareStub::MinorKey() { 6564 int CompareStub::MinorKey() {
6565 // Encode the three parameters in a unique 16 bit value. 6565 // Encode the three parameters in a unique 16 bit value.
6566 ASSERT(static_cast<unsigned>(cc_) < (1 << 14)); 6566 ASSERT((static_cast<unsigned>(cc_) >> 26) < (1 << 16));
6567 int nnn_value = (never_nan_nan_ ? 2 : 0); 6567 int nnn_value = (never_nan_nan_ ? 2 : 0);
6568 if (cc_ != eq) nnn_value = 0; // Avoid duplicate stubs. 6568 if (cc_ != eq) nnn_value = 0; // Avoid duplicate stubs.
6569 return (static_cast<unsigned>(cc_) >> 26) | nnn_value | (strict_ ? 1 : 0); 6569 return (static_cast<unsigned>(cc_) >> 26) | nnn_value | (strict_ ? 1 : 0);
6570 } 6570 }
6571 6571
6572 6572
6573 #undef __ 6573 #undef __
6574 6574
6575 } } // namespace v8::internal 6575 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698