Moved deleting the indexed db context to the WebKitContext destructor.

chrome/browser/in_process_webkit/webkit_context.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/in_process_webkit/webkit_context.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/browser_thread.h"
 #include "chrome/browser/profile.h"
+#include "chrome/browser/prefs/pref_service.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/notification_details.h"
+#include "chrome/common/notification_source.h"
+#include "chrome/common/notification_type.h"
+#include "chrome/common/pref_names.h"
 
 WebKitContext::WebKitContext(Profile* profile)
     : data_path_(profile->IsOffTheRecord() ? FilePath() : profile->GetPath()),
       is_incognito_(profile->IsOffTheRecord()),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           dom_storage_context_(new DOMStorageContext(this))),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           indexed_db_context_(new IndexedDBContext(this))) {
+  PrefService* prefs = profile->GetPrefs();

[jochen (gone - plz use gerrit), 2010/11/29 13:29:33]

hum. if the profile is off the record, you should just set
clear_local_state_on_exit_ to false and not observe the pref changes

[pastarmovj, 2010/11/29 13:45:12]

Done.

+  clear_local_state_on_exit_ = prefs->GetBoolean(prefs::kClearSiteDataOnExit);
+  pref_change_registrar_.Init(prefs);
+  pref_change_registrar_.Add(prefs::kClearSiteDataOnExit, this);
 }
 
 WebKitContext::~WebKitContext() {
   // If the WebKit thread was ever spun up, delete the object there.  The task
   // will just get deleted if the WebKit thread isn't created (which only
   // happens during testing).
   DOMStorageContext* dom_storage_context = dom_storage_context_.release();
   if (!BrowserThread::DeleteSoon(
           BrowserThread::WEBKIT, FROM_HERE, dom_storage_context)) {
     // The WebKit thread wasn't created, and the task got deleted without
     // freeing the DOMStorageContext, so delete it manually.
     delete dom_storage_context;
   }
 
+  indexed_db_context_->set_clear_local_state_on_exit_(
+      clear_local_state_on_exit_);
   IndexedDBContext* indexed_db_context = indexed_db_context_.release();
   if (!BrowserThread::DeleteSoon(
           BrowserThread::WEBKIT, FROM_HERE, indexed_db_context)) {
     delete indexed_db_context;
   }
 }
 
 void WebKitContext::PurgeMemory() {
   if (!BrowserThread::CurrentlyOn(BrowserThread::WEBKIT)) {
     BrowserThread::PostTask(
@@ skipping 28 matching lines @@
     BrowserThread::PostTask(
         BrowserThread::WEBKIT, FROM_HERE,
         NewRunnableMethod(this, &WebKitContext::DeleteSessionStorageNamespace,
                           session_storage_namespace_id));
     return;
   }
 
   dom_storage_context_->DeleteSessionStorageNamespace(
       session_storage_namespace_id);
 }
+
+void WebKitContext::Observe(NotificationType type,
+                            const NotificationSource& source,
+                            const NotificationDetails& details) {
+  if (NotificationType::PREF_CHANGED == type) {
+    std::string* name = Details<std::string>(details).ptr();
+    PrefService* prefs = Source<PrefService>(source).ptr();
+    if (prefs::kClearSiteDataOnExit == *name)
+    {

[jochen (gone - plz use gerrit), 2010/11/29 13:29:33]

{ on previous line

[pastarmovj, 2010/11/29 13:45:12]

Done.

+      clear_local_state_on_exit_ = prefs->GetBoolean(

[jochen (gone - plz use gerrit), 2010/11/29 13:29:33]

i'd wrap around after the =

[pastarmovj, 2010/11/29 13:45:12]

Done.

+          prefs::kClearSiteDataOnExit);
+    }
+  }
+}