Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 5357012: Use regular string ops, instead of urlparse.urljoin. (Closed)

Created:
10 years ago by davidjames
Modified:
9 years, 4 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Use regular string ops, instead of urlparse.urljoin. urlparse.urljoin('scheme:foo/bar/', 'baz') == 'baz', so it doesn't work the way I expected. Instead, let's use regular string joins. BUG=chromium-os:5311 TEST=Ran buildbot in test mode. Change-Id: Iea4205573db602e0cc20af24a77d255d17e79221 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=74f0f17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M prebuilt.py View 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davidjames
10 years ago (2010-11-30 21:49:12 UTC) #1
diandersAtChromium
10 years ago (2010-11-30 21:54:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698