Issue 5355005: Don't reset BlockThirdPartyCookies to it's default value if the preference it managed.

Issue 5355005: Don't reset BlockThirdPartyCookies to it's default value if the preference it managed. (Closed)

Created:
10 years ago by markusheintz_

Modified:
9 years, 6 months ago

Reviewers:
Nico, jochen (gone - plz use gerrit)

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't reset BlockThirdPartyCookies to it's default value if the preference it managed. BUG=64460 TEST=host_content_settings_map_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67705

Patch Set 1 #

Total comments: 6

Patch Set 2 : " #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
	M	chrome/browser/host_content_settings_map.cc	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
	M	chrome/browser/host_content_settings_map_unittest.cc	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

LGTM given trybot happiness and after fixing my nits http://codereview.chromium.org/5355005/diff/1/chrome/browser/host_content_settings_map.cc File chrome/browser/host_content_settings_map.cc (right): http://codereview.chromium.org/5355005/diff/1/chrome/browser/host_content_settings_map.cc#newcode816 chrome/browser/host_content_settings_map.cc:816: ...

10 years ago (2010-11-29 13:31:28 UTC) #2

markusheintz_

10 years ago (2010-11-29 13:58:02 UTC) #3

http://codereview.chromium.org/5355005/diff/1/chrome/browser/host_content_set...
File chrome/browser/host_content_settings_map.cc (right):

http://codereview.chromium.org/5355005/diff/1/chrome/browser/host_content_set...
chrome/browser/host_content_settings_map.cc:816: // preference is not managaged
anymore.
On 2010/11/29 13:31:28, jochen wrote:
> managed

Done.

http://codereview.chromium.org/5355005/diff/1/chrome/browser/host_content_set...
File chrome/browser/host_content_settings_map_unittest.cc (right):

http://codereview.chromium.org/5355005/diff/1/chrome/browser/host_content_set...
chrome/browser/host_content_settings_map_unittest.cc:993:
prefs->SetManagedPref(prefs::kBlockThirdPartyCookies,
Value::CreateBooleanValue(true));
On 2010/11/29 13:31:28, jochen wrote:
> 80c

Done.

http://codereview.chromium.org/5355005/diff/1/chrome/browser/host_content_set...
chrome/browser/host_content_settings_map_unittest.cc:994:
prefs->SetUserPref(prefs::kBlockThirdPartyCookies,
Value::CreateBooleanValue(true));
On 2010/11/29 13:31:28, jochen wrote:
> 80c

Done.

Expand Messages | Collapse Messages