Fix a problem with the delete-after-reboot code. Removing pending renames of ...

Fix a problem with the delete-after-reboot code. Removing pending renames of files not currently on disk would fail due to calls to GetShortPathName failing for already-deleted files. Now we just attempt to keep using the long path names for the already-deleted-file case. Also test.

BUG=64503
TEST=Uninstall CF while it is in use. Delete the in use files. Reinstall. Ensure that the CF files are no longer scheduled for deletion by looking at HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\PendingFileRenameOperations.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67889

[grt (UTC plus 2), 2010-12-01 04:46:54]

LGTM with two nits.

http://codereview.chromium.org/5354006/diff/1/chrome/installer/util/delete_af...
File chrome/installer/util/delete_after_reboot_helper_unittest.cc (right):

http://codereview.chromium.org/5354006/diff/1/chrome/installer/util/delete_af...
chrome/installer/util/delete_after_reboot_helper_unittest.cc:220: for (int i =
0; i < arraysize(expected_paths); i++) {
Prefer preincrement.

http://codereview.chromium.org/5354006/diff/1/chrome/installer/util/delete_af...
chrome/installer/util/delete_after_reboot_helper_unittest.cc:226: iter++;
Prefer preincrement (which has lower cost in this case).

[robertshield, 2010-12-01 14:50:04]

Thanks!

http://codereview.chromium.org/5354006/diff/1/chrome/installer/util/delete_af...
File chrome/installer/util/delete_after_reboot_helper_unittest.cc (right):

http://codereview.chromium.org/5354006/diff/1/chrome/installer/util/delete_af...
chrome/installer/util/delete_after_reboot_helper_unittest.cc:220: for (int i =
0; i < arraysize(expected_paths); i++) {
On 2010/12/01 04:46:54, grt wrote:
> Prefer preincrement.

Done.

http://codereview.chromium.org/5354006/diff/1/chrome/installer/util/delete_af...
chrome/installer/util/delete_after_reboot_helper_unittest.cc:226: iter++;
On 2010/12/01 04:46:54, grt wrote:
> Prefer preincrement (which has lower cost in this case).

Done.