Issue 5352005: Add 'prioritize' command to cgpt tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5352005: Add 'prioritize' command to cgpt tool. (Closed)

Created:
10 years ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, adlr

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Add 'prioritize' command to cgpt tool. This lets us reorder the priority of all the kernel partitions with a single command, instead of a bunch of complicated and error-prone shell script logic. Change-Id: I21d39763ec5a748488d5319a987bcfe7c34ce4d0 BUG=chromium-os:9167 TEST=manual In the chroot, do this: cd ~/trunk/src/platform/vboot_reference make make runtests make clean Everything should pass. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3430b32

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+519 lines, -41 lines)			Patch
M	cgpt/Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	cgpt/cgpt.h	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	cgpt/cgpt.c	View	3 chunks	+19 lines, -5 lines	0 comments	Download
M	cgpt/cgpt_common.c	View	4 chunks	+22 lines, -11 lines	0 comments	Download
M	cgpt/cmd_find.c	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	cgpt/cmd_prioritize.c	View	1 chunk	+314 lines, -0 lines	0 comments	Download
M	cgpt/cmd_show.c	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	firmware/lib/cgptlib/cgptlib.c	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	firmware/lib/cgptlib/include/gpt.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	firmware/version.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/common.sh	View	1 chunk	+21 lines, -3 lines	0 comments	Download
M	tests/run_cgpt_tests.sh	View	2 chunks	+127 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

Replacing 5144002, since the changes got screwed up somehow. Please take a look here, instead. ...

10 years ago (2010-11-29 19:48:42 UTC) #2

LGTM, thanks

Expand Messages | Collapse Messages