Issue 5350003: Move audio output number limit to AudioManager.

Issue 5350003: Move audio output number limit to AudioManager. (Closed)

Created:
10 years ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google, scherkus (not reviewing)

CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, ben+cc_chromium.org, ddorwin+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, awong, brettw-cc_chromium.org, pam+watch_chromium.org, scherkus (not reviewing), Alpha Left Google

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move audio output number limit to AudioManager. BUG=39825 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67618

Patch Set 1 : - #

Patch Set 2 : - #

Patch Set 3 : fixed compilation on mac. #

Total comments: 4

Patch Set 4 : - #

Patch Set 5 : - #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -52 lines)			Patch
M	chrome/browser/renderer_host/audio_renderer_host.cc	View		3 chunks	+0 lines, -38 lines	0 comments	Download
M	media/audio/linux/audio_manager_linux.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	media/audio/mac/audio_manager_mac.h	View	1 2 3 4	2 chunks	+6 lines, -3 lines	0 comments	Download
M	media/audio/mac/audio_manager_mac.cc	View	1 2 3	5 chunks	+57 lines, -2 lines	0 comments	Download
M	media/audio/win/audio_manager_win.h	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	media/audio/win/audio_manager_win.cc	View	1 2 3	5 chunks	+21 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM w/ nits http://codereview.chromium.org/5350003/diff/9001/media/audio/mac/audio_manager_mac.cc File media/audio/mac/audio_manager_mac.cc (right): http://codereview.chromium.org/5350003/diff/9001/media/audio/mac/audio_manager_mac.cc#newcode28 media/audio/mac/audio_manager_mac.cc:28: size_t GetMaxAudioOutputStreamsAllowed() { what about caching ...

10 years ago (2010-11-29 22:42:13 UTC) #3

Sergey Ulanov

10 years ago (2010-11-29 22:58:12 UTC) #4

http://codereview.chromium.org/5350003/diff/9001/media/audio/mac/audio_manage...
File media/audio/mac/audio_manager_mac.cc (right):

http://codereview.chromium.org/5350003/diff/9001/media/audio/mac/audio_manage...
media/audio/mac/audio_manager_mac.cc:28: size_t
GetMaxAudioOutputStreamsAllowed() {
On 2010/11/29 22:42:13, scherkus wrote:
> what about caching the result as a static and lazy-initializing the value?
> 
> we could avoid having max_output_streams_ variable

Done.

http://codereview.chromium.org/5350003/diff/9001/media/audio/mac/audio_manage...
File media/audio/mac/audio_manager_mac.h (right):

http://codereview.chromium.org/5350003/diff/9001/media/audio/mac/audio_manage...
media/audio/mac/audio_manager_mac.h:36: virtual ~AudioManagerMac() {};
On 2010/11/29 22:42:13, scherkus wrote:
> nit: can you move this impl to .cc file?

Done.

Expand Messages | Collapse Messages