Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chromite/lib/cros_build_lib.py

Issue 5347008: Fix handling of array arguments in chromite cros_build_lib. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromite/lib/cros_build_lib.py
diff --git a/chromite/lib/cros_build_lib.py b/chromite/lib/cros_build_lib.py
index 1d2860ba93f8c8ae04b9467b8fba2c4e053b7da9..87fa133b75cab27180bd1c575ec2fe655fc78e45 100644
--- a/chromite/lib/cros_build_lib.py
+++ b/chromite/lib/cros_build_lib.py
@@ -78,9 +78,8 @@ def RunCommand(cmd, print_cmd=True, error_ok=False, error_message=None,
cmd_result.cmd = cmd_str
try:
- proc = subprocess.Popen(cmd_str, cwd=cwd, stdin=stdin,
- stdout=stdout, stderr=stderr,
- shell=shell)
+ proc = subprocess.Popen(cmd, cwd=cwd, stdin=stdin, stdout=stdout,
+ stderr=stderr, shell=shell)
(cmd_result.output, cmd_result.error) = proc.communicate(input)
if exit_code:
cmd_result.returncode = proc.returncode
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698