Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: bin/cbuildbot_unittest.py

Issue 5344002: Update cbuildbot.py and prebuilt.py to deduplicate preflight prebuilts. (Closed) Base URL: None@preflight_upload
Patch Set: Reset against cros/master Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bin/cbuildbot.py ('k') | chromite/lib/binpkg.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/cbuildbot_unittest.py
diff --git a/bin/cbuildbot_unittest.py b/bin/cbuildbot_unittest.py
index 87bfc363c293b6a1f1460714664be24425e18bf7..b3a4009a90a96feb899f53765cbaa57ffd63c2d9 100755
--- a/bin/cbuildbot_unittest.py
+++ b/bin/cbuildbot_unittest.py
@@ -208,18 +208,26 @@ class CBuildBotTest(mox.MoxTestBase):
def testUploadPublicPrebuilts(self):
"""Test _UploadPrebuilts with a public location."""
- check = mox.And(mox.IsA(list), mox.In('gs://chromeos-prebuilt'))
+ binhost = 'http://www.example.com'
+ binhosts = [binhost, None]
+ check = mox.And(mox.IsA(list), mox.In(binhost), mox.Not(mox.In(None)),
+ mox.In('gs://chromeos-prebuilt'))
cbuildbot.RunCommand(check, cwd='%s/src/scripts' % self._buildroot)
self.mox.ReplayAll()
- cbuildbot._UploadPrebuilts(self._buildroot, self._test_board, 'public')
+ cbuildbot._UploadPrebuilts(self._buildroot, self._test_board, 'public',
+ binhosts)
self.mox.VerifyAll()
def testUploadPrivatePrebuilts(self):
"""Test _UploadPrebuilts with a private location."""
- check = mox.And(mox.IsA(list), mox.In('chromeos-images:/var/www/prebuilt/'))
+ binhost = 'http://www.example.com'
+ binhosts = [binhost, None]
+ check = mox.And(mox.IsA(list), mox.In(binhost), mox.Not(mox.In(None)),
+ mox.In('chromeos-images:/var/www/prebuilt/'))
cbuildbot.RunCommand(check, cwd='%s/src/scripts' % self._buildroot)
self.mox.ReplayAll()
- cbuildbot._UploadPrebuilts(self._buildroot, self._test_board, 'private')
+ cbuildbot._UploadPrebuilts(self._buildroot, self._test_board, 'private',
+ binhosts)
self.mox.VerifyAll()
« no previous file with comments | « bin/cbuildbot.py ('k') | chromite/lib/binpkg.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698