Issue 5341004: Chrome should re-register device when DMServer doesn't recognize token

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5341004: Chrome should re-register device when DMServer doesn't recognize token (Closed)

Created:
10 years, 1 month ago by danno

Modified:
9 years, 7 months ago

Reviewers:
markusheintz_, Mattias Nissler (ping if slow)

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Chrome should re-generate Device Token when DMServer doesn't recognize it. BUG=64318 TEST=DeviceManagementPolicyProviderTest.DeviceNotFound Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67440

Patch Set 1 #

Patch Set 2 : fix 80 col #

Total comments: 1

Patch Set 3 : review feedback #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -8 lines)			Patch
	M	chrome/browser/policy/device_management_policy_provider.cc	View	1 2	1 chunk	+15 lines, -8 lines	0 comments	Download
	M	chrome/browser/policy/device_management_policy_provider_unittest.cc	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

10 years ago (2010-11-25 09:03:28 UTC) #3

LGTM with a nit.

http://codereview.chromium.org/5341004/diff/4001/chrome/browser/policy/device...
File chrome/browser/policy/device_management_policy_provider.cc (right):

http://codereview.chromium.org/5341004/diff/4001/chrome/browser/policy/device...
chrome/browser/policy/device_management_policy_provider.cc:111: if (code ==
DeviceManagementBackend::kErrorServiceDeviceNotFound) {
please also add kErrorDeviceManagementTokenInvalid

Expand Messages | Collapse Messages