Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: base/scoped_temp_dir_unittest.cc

Issue 5340004: Make ScopedTempDir::Delete return a bool so that its functionality can be te... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« base/scoped_temp_dir.h ('K') | « base/scoped_temp_dir.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_util.h" 5 #include "base/file_util.h"
6 #include "base/platform_file.h"
6 #include "base/scoped_temp_dir.h" 7 #include "base/scoped_temp_dir.h"
7 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
8 9
9 TEST(ScopedTempDir, FullPath) { 10 TEST(ScopedTempDir, FullPath) {
10 FilePath test_path; 11 FilePath test_path;
11 file_util::CreateNewTempDirectory(FILE_PATH_LITERAL("scoped_temp_dir"), 12 file_util::CreateNewTempDirectory(FILE_PATH_LITERAL("scoped_temp_dir"),
12 &test_path); 13 &test_path);
13 14
14 // Against an existing dir, it should get destroyed when leaving scope. 15 // Against an existing dir, it should get destroyed when leaving scope.
15 EXPECT_TRUE(file_util::DirectoryExists(test_path)); 16 EXPECT_TRUE(file_util::DirectoryExists(test_path));
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 EXPECT_FALSE(dir.CreateUniqueTempDir()); 81 EXPECT_FALSE(dir.CreateUniqueTempDir());
81 dir.Delete(); 82 dir.Delete();
82 EXPECT_TRUE(dir.CreateUniqueTempDir()); 83 EXPECT_TRUE(dir.CreateUniqueTempDir());
83 EXPECT_FALSE(dir.CreateUniqueTempDir()); 84 EXPECT_FALSE(dir.CreateUniqueTempDir());
84 ScopedTempDir other_dir; 85 ScopedTempDir other_dir;
85 other_dir.Set(dir.Take()); 86 other_dir.Set(dir.Take());
86 EXPECT_TRUE(dir.CreateUniqueTempDir()); 87 EXPECT_TRUE(dir.CreateUniqueTempDir());
87 EXPECT_FALSE(dir.CreateUniqueTempDir()); 88 EXPECT_FALSE(dir.CreateUniqueTempDir());
88 EXPECT_FALSE(other_dir.CreateUniqueTempDir()); 89 EXPECT_FALSE(other_dir.CreateUniqueTempDir());
89 } 90 }
91
92 #if defined(OS_WIN)
93 TEST(ScopedTempDir, LockedTempDir) {
94 ScopedTempDir dir;
95 EXPECT_TRUE(dir.CreateUniqueTempDir());
96 int file_flags = base::PLATFORM_FILE_CREATE_ALWAYS |
97 base::PLATFORM_FILE_WRITE;
98 base::PlatformFileError error_code = base::PLATFORM_FILE_OK;
99 FilePath file_path(dir.path().Append(FILE_PATH_LITERAL("temp")));
100 base::PlatformFile file = base::CreatePlatformFile(file_path, file_flags,
101 NULL, &error_code);
102 EXPECT_NE(base::kInvalidPlatformFileValue, file);
103 EXPECT_EQ(base::PLATFORM_FILE_OK, error_code);
104 EXPECT_FALSE(dir.Delete()); // We should not be able to delete.
105 EXPECT_FALSE(dir.path().empty()); // We should still have a valid path.
106 EXPECT_TRUE(base::ClosePlatformFile(file));
107 // Now, we should be able to delete.
108 EXPECT_TRUE(dir.Delete());
109 }
110 #endif // defined(OS_WIN)
OLDNEW
« base/scoped_temp_dir.h ('K') | « base/scoped_temp_dir.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698