Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 5339011: For the boards already have DB directories, remove the default DB. (Closed)

Created:
10 years ago by Tom Wai-Hong Tam
Modified:
9 years, 5 months ago
Reviewers:
Hung-Te
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

For the boards already have DB directories, remove the default DB. The default DB is an all-pass DB. If no DB found, the hardware_Components test falls back to the all-pass one and skip the real check. In order to prevent skipping the check, remove the default DB in the boards already have DB directories. TEST=run "image_to_usb.sh --factory" and check the default DB removed BUG=chrome-os-partner:1737 Change-Id: Ia25f2551a5eba3a95fe736e86bfe52c340f329a8 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fb5ce16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M mod_for_factory_scripts/500populateQualDbs View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tom Wai-Hong Tam
10 years ago (2010-11-30 03:03:33 UTC) #1
Hung-Te
10 years ago (2010-11-30 03:14:54 UTC) #2
LGTM, thanks for fixing this.

Powered by Google App Engine
This is Rietveld 408576698