Issue 5339006: Add RunCommandCaptureOutput as a helper method. It's like RunCommand, but you

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5339006: Add RunCommandCaptureOutput as a helper method. It's like RunCommand, but you (Closed)

Created:
10 years, 1 month ago by dgarrett

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Add RunCommandCaptureOutput as a helper method. It's like RunCommand, but you can run the command, capture it's error code and output together. This is to support tests that need to capture output of image_to_live, and to know if it succeeded. Change-Id: If674b6d79697c0f0b5c96be9fc83adbed9b9893e BUG=chromium-os:9502 TEST=Ran by hand Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cd33866

Patch Set 1 #

Patch Set 2 : Fix comments. #

Patch Set 3 : Tweaked return value. #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -1 line)			Patch
	M	lib/cros_build_lib.py	View	1 2	2 chunks	+45 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM w/ one suggestion. Might be better to always return a tuple of 3 but ...

10 years ago (2010-11-29 20:39:41 UTC) #3

dgarrett

10 years ago (2010-11-29 20:52:46 UTC) #4

Makes sense.

On Mon, Nov 29, 2010 at 12:39 PM, <sosa@chromium.org> wrote:

> LGTM w/ one suggestion.  Might be better to always return a tuple of 3 but
> for
> combine_stderr options, return (exit_code, stdout, None)
>
>
> http://codereview.chromium.org/5339006/
>



-- 
Don

Expand Messages | Collapse Messages